Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Backups field a pointer for client.Create #4058

Closed
wants to merge 1 commit into from
Closed

Make the Backups field a pointer for client.Create #4058

wants to merge 1 commit into from

Conversation

cbandy
Copy link
Member

@cbandy cbandy commented Dec 19, 2024

Pointer is the way to omit a struct from serialization.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • Testing enhancement

@cbandy cbandy requested a review from benjaminjb December 19, 2024 20:02
cbandy
cbandy commented Dec 19, 2024
View reviewed changes
internal/testing/validation/postgrescluster_test.go
Comment on lines 32 to 33
postgresVersion: 16,
backups: {
pgbackrest: {
repos: [{ name: repo1 }],
},
},
instances: [{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 The pointer allows the cc.Create call below to succeed with this.

@cbandy cbandy marked this pull request as draft December 19, 2024 22:40
@cbandy cbandy closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminjb benjaminjb Awaiting requested review from benjaminjb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cbandy