PostgresCluster names and namespaces for support #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds all reachable postgrescluster names and their namespaces to support export. Issue: PGO-272
tony-landreth
force-pushed
the
add-clusters-namespaces-to-export
branch
from
6a1cfe8 to
92536d3
Compare
benjaminjb
reviewed
Oct 30, 2023
| @@ -71,6 +71,7 @@ kubectl pgo support export daisy --monitoring-namespace another-namespace --outp | |||
| | Note: No data or k8s secrets are collected. | |||
| └──────────────────────────────────────────────────────────────── | |||
| Collecting PGO CLI version... | |||
| Collecting names and namespaces for PostgresClusters... | |||
benjaminjb
approved these changes
Oct 30, 2023
cbandy
reviewed
Oct 31, 2023
Comment on lines
+502
to
+515
| ns, found, err := unstructured.NestedString(item.Object, "metadata", "namespace") | ||
| if !found { | ||
| return fmt.Errorf("key not found: metadata.namespace") | ||
| } | ||
| if err != nil { | ||
| return err | ||
| } | ||
| name, found, err := unstructured.NestedString(item.Object, "metadata", "name") | ||
| if !found { | ||
| return fmt.Errorf("key not found: metadata.name") | ||
| } | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
🌱 Every PostgresCluster returned from the API will have a namespace and name. There's also no harm in proceeding if we do encounter something unexpected. I think we prefer to gather the remainder of the list rather than give up early.
Suggested change
| ns, found, err := unstructured.NestedString(item.Object, "metadata", "namespace") | |
| if !found { | |
| return fmt.Errorf("key not found: metadata.namespace") | |
| } | |
| if err != nil { | |
| return err | |
| } | |
| name, found, err := unstructured.NestedString(item.Object, "metadata", "name") | |
| if !found { | |
| return fmt.Errorf("key not found: metadata.name") | |
| } | |
| if err != nil { | |
| return err | |
| } | |
| ns, _, _ := unstructured.NestedString(item.Object, "metadata", "namespace") | |
| name, _, _ := unstructured.NestedString(item.Object, "metadata", "name") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all reachable postgrescluster names and their namespaces to support export.
Issue: PGO-272