Adds an overwrite flag to force annotation updates #70
Conversation
tony-landreth
force-pushed
the
add-overwrite-to-backup
branch
from
efdce21 to
ddd8b71
Compare
tony-landreth
force-pushed
the
add-overwrite-to-backup
branch
4 times, most recently
from
0e4c26f to
f7c4e7b
Compare
| @@ -53,15 +53,19 @@ pgo backup hippo | |||
| # Update the 'backups.pgbackrest.manual.repoName' and 'backups.pgbackrest.manual.options' fields | |||
| # on the 'hippo' postgrescluster and trigger a backup | |||
| pgo backup hippo --repoName="repo1" --options="--type=full" | |||
|
|
|||
There was a problem hiding this comment.
Not your change, but can you look at line 40 -- I don't like that it uses the word "overwrite" when that's not what we do unless you use the overwrite flag
There was a problem hiding this comment.
Does the new text work?
There was a problem hiding this comment.
I think there's ~3 cases here that we (maybe) want to cover:
a) take a backup with the settings already in the spec
b) take a backup with new settings that you write to the spec
c) take a backup with new settings that you write to the spec -- even if someone else owns those settings.
Maybe something like (but better than):
Backup allows you to take a backup of a PostgreSQL cluster, either using
the current "spec.backups.pgbackrest.manual" settings on the PostgreSQL cluster
or by writing those settings using the flags (potentially overwriting them with the
`--force-conflicts` flag).
(I don't think we actually want parentheses in our docs. Maybe we just want to say "you can take backups with the settings that are there or write those settings" and mention the overwrite situation in the flag description? No, I think people will run into that, we probably want to bring it up in this summary.)
There was a problem hiding this comment.
What about this?
tony-landreth
force-pushed
the
add-overwrite-to-backup
branch
6 times, most recently
from
bbdcd72 to
7cec13c
Compare
tony-landreth
force-pushed
the
add-overwrite-to-backup
branch
from
7cec13c to
3f35acf
Compare
tony-landreth
force-pushed
the
add-overwrite-to-backup
branch
6 times, most recently
from
190e814 to
677c983
Compare
tony-landreth
force-pushed
the
add-overwrite-to-backup
branch
from
9b476ce to
fe4e162
Compare
Issue: PGO-39