Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FalconNodeSensor defaults #612

Closed
wants to merge 1 commit into from

Conversation

gpontejos
Copy link
Collaborator

@gpontejos gpontejos commented Dec 19, 2024

This adds the missing default markers to accommodated for nested objects within the FalconNodeSensor Spec.
Operator log output from a Get() to the API when starting reconciliation for a new deployment when only falcon_api is set in the Spec:

{
    "controller": "falconnodesensor",
    "controllerGroup": "falcon.crowdstrike.com",
    "controllerKind": "FalconNodeSensor",
    "FalconNodeSensor": {
        "name": "falcon-node-sensor"
    },
    "namespace": "",
    "name": "falcon-node-sensor",
    "reconcileID": "1a539e00-6d1c-45c6-b1b8-a4f11c1c0039",
    "nodesensor.Spec": {
        "installNamespace": "falcon-system",
        "node": {
            "tolerations": [
                {
                    "key": "node-role.kubernetes.io/master",
                    "operator": "Exists",
                    "effect": "NoSchedule"
                },
                {
                    "key": "node-role.kubernetes.io/control-plane",
                    "operator": "Exists",
                    "effect": "NoSchedule"
                },
                {
                    "key": "node-role.kubernetes.io/infra",
                    "operator": "Exists",
                    "effect": "NoSchedule"
                }
            ],
            "nodeAffinity": {},
            "imagePullPolicy": "Always",
            "updateStrategy": {
                "type": "RollingUpdate",
                "rollingUpdate": {}
            },
            "terminationGracePeriod": 30,
            "serviceAccount": {},
            "disableCleanup": false,
            "resources": {
                "limits": {},
                "requests": {}
            },
            "backend": "bpf",
            "gke": {},
            "priorityClass": {},
            "advanced": {}
        },
        "falcon": {
            "apd": false,
            "trace": "none"
        },
        "falcon_api": {
            "cloud_region": "autodiscover",
            "client_id": "CLIENT_ID",
            "client_secret": "CLIENT_SECRET"
        }
    }
}

@gpontejos gpontejos requested a review from mhyson-cs December 19, 2024 21:34
@gpontejos gpontejos closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant