feat: allow sidecar sensor to customize namespace #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
redhatrises
commented
May 2, 2024
•
redhatrises
commented
- Useful for mixed EKS clusters
- Needed for certain customer workloads to be able to customize namespace.
- Prevents running a non-privileged workload next to a privileged workload
redhatrises
force-pushed
the
allow_sidecar_ns_kustomization
branch
2 times, most recently
from
a2531b7 to
8d93cee
Compare
cs-alphonse
reviewed
May 3, 2024
redhatrises
force-pushed
the
allow_sidecar_ns_kustomization
branch
3 times, most recently
from
71c3f1a to
6484fc6
Compare
pflanagan-cs
reviewed
May 7, 2024
internal/controller/falcon_container/falconcontainer_controller.go
Outdated
Show resolved
Hide resolved
- Useful for mixed EKS clusters - Prevents running a non-privileged workload next to a privileged workload
redhatrises
force-pushed
the
allow_sidecar_ns_kustomization
branch
from
6484fc6 to
b10105c
Compare
pflanagan-cs
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.