-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
breaking-change: Fix main branch typescript errors (#83)
BREAKING CHANGE: Removing types and updating TypeScript version to support Glint properly. The main branch build is currently red due to the Glint dependency updates. This gets things back on track. We are making a breaking change as updating underlying TypeScript changes is considered as such (CrowdStrike/ember-headless-table#176). * chore: Upgrade glint dependencies * chore: Allow any ember-source + typescript * chore: Glint only supports TSv4.8+ * chore: Upgrade ember-source + resolver Started getting type errors with resolver: "Module '"@ember/owner"' has no exported member 'Resolver'. Did you mean to use 'import Resolver from "@ember/owner"' instead?" ember-resolver now ships with their own types rather than the types namespace * chore: Remove commitlint * chore: Update babel/core + qunit deps * chore: Add @types/ember__owner dependency * chore: Add ember/string as a dependency for tests * chore: Ignore glint errors for now * chore: Convert tests to gts * fix: Remove unneeded peerDependencies * fix: Remove unneeded types/ember packages These libraries now ship with their own types, so we no longer need the ones coming from the types namespace anymore. --------- Co-authored-by: Simon Ihmig <[email protected]>
- Loading branch information
1 parent
b994274
commit a732f56
Showing
8 changed files
with
285 additions
and
2,042 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,20 +37,6 @@ jobs: | |
run: pnpm lint | ||
|
||
|
||
|
||
commits: | ||
name: Commit Messages | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
- uses: ./.github/actions/pnpm | ||
- uses: wagoid/[email protected] | ||
with: | ||
configFile: 'commitlint.config.cjs' | ||
|
||
|
||
build: | ||
name: Build Tests | ||
needs: [install_dependencies] | ||
|
@@ -72,9 +58,8 @@ jobs: | |
fail-fast: true | ||
matrix: | ||
typescript-scenario: | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
|
@@ -89,7 +74,6 @@ jobs: | |
pnpm --filter test-app exec glint --version; | ||
pnpm --filter test-app exec glint; | ||
default_tests: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,18 +3,18 @@ template: "v2-addon" | |
|
||
# --------------------- | ||
|
||
addon: './ember-velcro' | ||
testApp: './test-app' | ||
addon: "./ember-velcro" | ||
testApp: "./test-app" | ||
|
||
# https://github.com/pnpm/pnpm/issues/4965 | ||
fixes: ['pnpm#4965'] | ||
fixes: ["pnpm#4965"] | ||
|
||
lint: | ||
commits: true | ||
cmd: 'pnpm lint' | ||
cmd: "pnpm lint" | ||
|
||
build: | ||
run: 'pnpm build' | ||
run: "pnpm build" | ||
expect: | | ||
index.js | ||
index.js.map | ||
|
@@ -26,9 +26,8 @@ support: | |
ember-try: true | ||
glint: true | ||
typescript: | ||
- "[email protected]" | ||
- "[email protected]" | ||
- "[email protected]" | ||
- "[email protected]" | ||
- "[email protected]" | ||
|
||
release: | ||
semantic: true |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.