Skip to content

Commit

Permalink
breaking-change: Fix main branch typescript errors (#83)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Removing types and updating TypeScript version to support Glint properly. The main branch build is currently red due to the Glint dependency updates.  This gets things back on track.  We are making a breaking change as updating underlying TypeScript changes is considered as such (CrowdStrike/ember-headless-table#176).

* chore: Upgrade glint dependencies

* chore: Allow any ember-source + typescript

* chore: Glint only supports TSv4.8+

* chore: Upgrade ember-source + resolver

Started getting type errors with resolver:

"Module '"@ember/owner"' has no exported member 'Resolver'. Did you mean to use 'import Resolver from "@ember/owner"' instead?"

ember-resolver now ships with their own types rather than the types namespace

* chore: Remove commitlint

* chore: Update babel/core + qunit deps

* chore: Add @types/ember__owner dependency

* chore: Add ember/string as a dependency for tests

* chore: Ignore glint errors for now

* chore: Convert tests to gts

* fix: Remove unneeded peerDependencies

* fix: Remove unneeded types/ember packages

These libraries now ship with their own types, so we no longer need the ones coming from the types namespace anymore.

---------

Co-authored-by: Simon Ihmig <[email protected]>
  • Loading branch information
ynotdraw and simonihmig authored May 25, 2023
1 parent b994274 commit a732f56
Show file tree
Hide file tree
Showing 8 changed files with 285 additions and 2,042 deletions.
20 changes: 2 additions & 18 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,6 @@ jobs:
run: pnpm lint



commits:
name: Commit Messages
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: ./.github/actions/pnpm
- uses: wagoid/[email protected]
with:
configFile: 'commitlint.config.cjs'


build:
name: Build Tests
needs: [install_dependencies]
Expand All @@ -72,9 +58,8 @@ jobs:
fail-fast: true
matrix:
typescript-scenario:
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]

steps:
- uses: actions/checkout@v3
Expand All @@ -89,7 +74,6 @@ jobs:
pnpm --filter test-app exec glint --version;
pnpm --filter test-app exec glint;
default_tests:
Expand Down
15 changes: 7 additions & 8 deletions ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@ template: "v2-addon"

# ---------------------

addon: './ember-velcro'
testApp: './test-app'
addon: "./ember-velcro"
testApp: "./test-app"

# https://github.com/pnpm/pnpm/issues/4965
fixes: ['pnpm#4965']
fixes: ["pnpm#4965"]

lint:
commits: true
cmd: 'pnpm lint'
cmd: "pnpm lint"

build:
run: 'pnpm build'
run: "pnpm build"
expect: |
index.js
index.js.map
Expand All @@ -26,9 +26,8 @@ support:
ember-try: true
glint: true
typescript:
- "[email protected]"
- "[email protected]"
- "[email protected]"
- "[email protected]"
- "[email protected]"

release:
semantic: true
33 changes: 0 additions & 33 deletions commitlint.config.cjs

This file was deleted.

10 changes: 3 additions & 7 deletions ember-velcro/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,27 +51,23 @@
"test": "echo 'A v2 addon does not have tests, run tests in test-app'",
"prepack": "rollup --config ./rollup.config.js"
},
"peerDependencies": {
"@glint/environment-ember-loose": "^0.9.4",
"@glint/template": "^0.9.5"
},
"dependencies": {
"@embroider/addon-shim": "^1.0.0",
"@floating-ui/dom": "^1.0.1",
"ember-functions-as-helper-polyfill": "^2.1.1",
"ember-modifier": "^3.2.7"
},
"devDependencies": {
"@babel/core": "^7.19.3",
"@babel/core": "^7.21.0",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-proposal-decorators": "^7.19.3",
"@babel/preset-typescript": "^7.18.6",
"@babel/runtime": "^7.19.4",
"@embroider/addon-dev": "^2.0.0",
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
"@glint/environment-ember-loose": "^0.9.5",
"@glint/template": "^0.9.5",
"@glint/environment-ember-loose": "^1.0.2",
"@glint/template": "^1.0.2",
"@nullvoxpopuli/eslint-configs": "^2.2.58",
"@rollup/plugin-babel": "^5.3.1",
"@semantic-release/changelog": "^6.0.0",
Expand Down
Loading

0 comments on commit a732f56

Please sign in to comment.