fix: use plugin name property as preferences key

CrowdStrike · Oct 9, 2023 · 01f5fd0 · 01f5fd0
1 parent 3de2542
commit 01f5fd0
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 11 deletions.
diff --git a/ember-headless-table/src/-private/preferences.ts b/ember-headless-table/src/-private/preferences.ts
@@ -1,6 +1,7 @@
 import { TrackedMap } from 'tracked-built-ins';
 
 import type {
+  PluginClass,
   PluginPreferenceFor,
   PluginPreferences,
   PreferencesAdapter as Adapter,
@@ -63,12 +64,13 @@ class TrackedPreferences {
     return [...this.plugins.values()].every((pluginPrefs) => pluginPrefs.isAtDefault);
   }
 
-  forPlugin(name: string) {
-    let existing = this.plugins.get(name);
+  forPlugin(klass: PluginClass<any>) {
+    let instance = Reflect.construct(klass, []) as PluginClass<any>;
+    let existing = this.plugins.get(instance.name);
 
     if (!existing) {
       existing = new TrackedPluginPrefs();
-      this.plugins.set(name, existing);
+      this.plugins.set(instance.name, existing);
     }
 
     return existing;

diff --git a/ember-headless-table/src/plugins/-private/base.ts b/ember-headless-table/src/plugins/-private/base.ts
@@ -158,7 +158,7 @@ export const preferences = {
        */
       delete(key: string) {
         let prefs = column.table.preferences;
-        let existing = prefs.storage.forPlugin(klass.name);
+        let existing = prefs.storage.forPlugin(klass);
         let columnPrefs = existing.forColumn(column.key);
 
         columnPrefs.delete(key);
@@ -170,7 +170,7 @@ export const preferences = {
        */
       get(key: string) {
         let prefs = column.table.preferences;
-        let existing = prefs.storage.forPlugin(klass.name);
+        let existing = prefs.storage.forPlugin(klass);
         let columnPrefs = existing.forColumn(column.key);
 
         return columnPrefs.get(key);
@@ -180,7 +180,7 @@ export const preferences = {
        */
       set(key: string, value: unknown) {
         let prefs = column.table.preferences;
-        let existing = prefs.storage.forPlugin(klass.name);
+        let existing = prefs.storage.forPlugin(klass);
         let columnPrefs = existing.forColumn(column.key);
 
         columnPrefs.set(key, value);
@@ -206,7 +206,7 @@ export const preferences = {
 
         for (let column of table.columns) {
           let prefs = column.table.preferences;
-          let existing = prefs.storage.forPlugin(klass.name);
+          let existing = prefs.storage.forPlugin(klass);
           let columnPrefs = existing.forColumn(column.key);
 
           columnPrefs.delete(key);
@@ -234,7 +234,7 @@ export const preferences = {
        */
       delete(key: string) {
         let prefs = table.preferences;
-        let existing = prefs.storage.forPlugin(klass.name);
+        let existing = prefs.storage.forPlugin(klass);
 
         existing.table.delete(key);
 
@@ -245,7 +245,7 @@ export const preferences = {
        */
       get(key: string) {
         let prefs = table.preferences;
-        let existing = prefs.storage.forPlugin(klass.name);
+        let existing = prefs.storage.forPlugin(klass);
 
         return existing.table.get(key);
       },
@@ -254,7 +254,7 @@ export const preferences = {
        */
       set(key: string, value: unknown) {
         let prefs = table.preferences;
-        let existing = prefs.storage.forPlugin(klass.name);
+        let existing = prefs.storage.forPlugin(klass);
 
         existing.table.set(key, value);
 

diff --git a/ember-headless-table/src/plugins/column-resizing/plugin.ts b/ember-headless-table/src/plugins/column-resizing/plugin.ts
@@ -307,7 +307,7 @@ export class TableMeta {
     let tablePrefs = this.table.preferences;
 
     for (let column of visibleColumnMetas) {
-      let existing = tablePrefs.storage.forPlugin('ColumnResizing');
+      let existing = tablePrefs.storage.forPlugin(ColumnResizing);
       let columnPrefs = existing.forColumn(column.key);
 
       columnPrefs.set('width', column.width.toString());