Fixes attribute errors in the Custom IOA module #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherHammond13
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes attribute errors in the Custom IOA module
Added features and functionality
Fixed a bug causing AttributeErrors when accessing cloud fields of
IoaRuleGroupandCustomIoaRuleobjects.Issues resolved
IoaRuleGroupandCustomIoaRuleobjects during__init__Notes
This does not attempt to separate local instances of the objects from clouded instances.
While this prevents a call to e.g.
rule.deletedfrom raising an exception, the property is not meaningful on local (to be created in the cloud) objects. I think it's worth considering whether keeping the current behaviour of throwing an error in these cases would be preferable. If so,__repr__can be fixed by changing its functionality in the case of local objects.