Auth: UI style fixes + demo width fix #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 41a75d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jmderby
commented
Oct 29, 2024
jmderby
commented
Oct 29, 2024
jmderby
changed the title
AlbertoElias
approved these changes
Oct 29, 2024
|
The powered by Crossmint looks like its using a different font. |
AlbertoElias
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR contains changes regarding broken styles once package was built and ran in a client app.
This PR also fixes small bug with demo screen width. I removed the viewport override from the twind file.
I worked with Pablo UX in collaborating these changes.
Test plan
Built app and ran from a completely separate client app running package via
yalc. Tested custom styles as well and everything worked as expected.Package updates
@crossmint/client-sdk-react-ui