Tree shaking: react-ui fix #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 769dd4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jmderby
commented
Oct 25, 2024
| @@ -15,7 +15,7 @@ | |||
| "types": "./dist/index.d.ts", | |||
| "files": ["dist", "src", "LICENSE"], | |||
| "scripts": { | |||
| "build": "tsup", | |||
| "build": "NODE_OPTIONS='--max-old-space-size=8192' tsup", | |||
There was a problem hiding this comment.
building locally wouldn't work until i increased the old-space memory size.
mPaella
reviewed
Oct 26, 2024
mPaella
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tree shaking capabilities back to the react-ui package
The solution around our twind issue was to add a TwindProvider that runs
installinside a useEffect on mount.Test plan
Tested build and styles worked as expected.
Package updates
@crossmint/client-sdk-react-ui