embedded-v3: send sdk info in iframe #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
mPaella
reviewed
Oct 17, 2024
| export type CrossmintEmbeddedCheckoutV3ServiceProps = { apiClient: CrossmintApiClient }; | ||
| export type CrossmintEmbeddedCheckoutV3ServiceProps = { | ||
| apiClient: CrossmintApiClient, | ||
| sdkMetadata: { |
There was a problem hiding this comment.
i think we have access to CrossmintApiClientInternalConfig["sdkMetadata"] from here, better to keep in sync
mPaella
approved these changes
Oct 17, 2024
mPaella
pushed a commit
that referenced
this pull request
Oct 22, 2024
* embedded-v3: send sdk info in iframe * refactor * fix * lint
mPaella
added a commit
that referenced
this pull request
Oct 22, 2024
* working * embed v3: dynamic connection (#798) * save * tweak off * cond * fix build * key * chain parse * save * embed v3: crypto tx sending (#818) working * embedded-v3: send sdk info in iframe (#819) * embedded-v3: send sdk info in iframe * refactor * fix * lint * v3: Rename component for v0 release (#820) * v3: rename component to alpha for now * duh * embed: update types (#822) types: sync * embed: useCrossmintCheckout (#823) * changeset --------- Co-authored-by: Pablo Egido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sending SDK info to the iframe
Test plan
Package updates