Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed v3: crypto tx sending #818

Merged
merged 1 commit into from
Oct 17, 2024
Merged

embed v3: crypto tx sending #818

merged 1 commit into from
Oct 17, 2024

Conversation

mPaella
Copy link
Collaborator

@mPaella mPaella commented Oct 17, 2024

Description

sending crypto txs on sol and evm

Test plan

tested both evm and sol

evm switching newtwork + sending working fine
sol sending is working fine, added a todo to work on network swtiching (its more complicated)

did e2e
image

Package updates

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
smart-wallet-auth-demo ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 3:18pm

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: e54f207

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +24 to +27
return await handleSolanaTransaction({
...commonParams,
primaryWallet,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They reuse the entire object right? commonParams could include primaryWallet as well I think

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its a ts thing, cuz of the isSolanaWallet and isEthereumWallet so it has to be after commonParams

@mPaella mPaella merged commit 34b0787 into feat/embed-v3 Oct 17, 2024
4 checks passed
@mPaella mPaella deleted the embed-v3/crypto-save branch October 17, 2024 15:47
mPaella added a commit that referenced this pull request Oct 22, 2024
mPaella added a commit that referenced this pull request Oct 22, 2024
* working

* embed v3: dynamic connection (#798)

* save

* tweak off

* cond

* fix build

* key

* chain parse

* save

* embed v3: crypto tx sending (#818)

working

* embedded-v3: send sdk info in iframe (#819)

* embedded-v3: send sdk info in iframe

* refactor

* fix

* lint

* v3: Rename component for v0 release (#820)

* v3: rename component to alpha for now

* duh

* embed: update types (#822)

types: sync

* embed: useCrossmintCheckout (#823)

* changeset

---------

Co-authored-by: Pablo Egido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants