-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embed v3: crypto tx sending #818
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
1f0fc28
to
e54f207
Compare
return await handleSolanaTransaction({ | ||
...commonParams, | ||
primaryWallet, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They reuse the entire object right? commonParams
could include primaryWallet as well I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its a ts thing, cuz of the isSolanaWallet
and isEthereumWallet
so it has to be after commonParams
* working * embed v3: dynamic connection (#798) * save * tweak off * cond * fix build * key * chain parse * save * embed v3: crypto tx sending (#818) working * embedded-v3: send sdk info in iframe (#819) * embedded-v3: send sdk info in iframe * refactor * fix * lint * v3: Rename component for v0 release (#820) * v3: rename component to alpha for now * duh * embed: update types (#822) types: sync * embed: useCrossmintCheckout (#823) * changeset --------- Co-authored-by: Pablo Egido <[email protected]>
Description
sending crypto txs on sol and evm
Test plan
tested both evm and sol
evm switching newtwork + sending working fine
sol sending is working fine, added a todo to work on network swtiching (its more complicated)
did e2e
Package updates