Auth Server SDK: Stores new auth material cookies #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c42899c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
AlbertoElias
changed the title
AlbertoElias
commented
Oct 17, 2024
AlbertoElias
force-pushed
the
albertoe/WAL-3060-auth-ssr-set-cookies
branch
from
40421e2
to
c42899c
Compare
afeight
reviewed
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the SSR doc, we needed a helper to store the cookies server-side. If a response is added to
getSessionthis is done automatically. If not, we provide astoreAuthMaterialhelper to do so.Test plan
Added tests and also tried in local node, express and remix apps.
Package updates
react-ui: patch
common-auth: patch
server-sdk: minor