Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More E2e tests, test improvements, add more testTags (pt. 2) #59

Merged
merged 45 commits into from
Aug 18, 2023

Conversation

deepanchal
Copy link
Contributor

@deepanchal deepanchal commented Aug 16, 2023

Description

  • chore(tools): bump maestro from v1.30.4 to v1.31.0 (2837b44)
  • chore(tools): set java version to adoptopenjdk-17.0.8+7 in tool-versions (29cf92e)
  • feat(designsystem): add testTag on OutlinedObfuscatingTextField based on isObfuscating property (d90b848)
  • chore(env): don't set MAESTRO_DRIVER_STARTUP optional env var in .envrc (facd8dd)
  • refactor(e2e): use testTags for e2e test ops in login-password-toggle.yaml (210eda8)
  • fix(designsystem): remove setting testTag inside CrisisCleanupNavigationBarItem as it generates invalid testTag (4b267b6)
  • feat(app): set testTag for bottom nav bar item using title in CrisisCleanupBottomBar (f6c6dce)
  • feat(cases): set testTag for dialog header on SelectIncidentDialog in SelectIncidentScreen (210f0ff)
  • feat(designsystem): add testTag on user avatar icon btn in TopAppBar > AvatarAttentionBadge (f4be522)
  • refactor(e2e): replace raw text with testTags in login-view.yaml e2e flow (1461f6e)
  • refactor(e2e): replace text with testTag in login.yaml e2e flow (db1e005)
  • refactor(e2e): replace text with testTag in logout.yaml e2e flow (d7383d2)
  • refactor(e2e): replace text with testTag id in profile-view.yaml e2e flow (f348169)
  • feat(commoncase): add testTag for every worksite result item based on worksite id in ExistingWorksitesList (348e52a)
  • feat(commoncase): add testTag for loading indicator in IncidentDropdownSelect (7a5e86c)
  • feat(cases): add testTag for incident search popup items in CasesSearchScreen (333b1ad)
  • feat(cases): add testTags for cases count view loading indicator in CasesScreen (ed23aaf)
  • feat(caseeditor): add testTags in CaseIncidentView (4128953)
  • feat(caseeeditor): add static and dynamic testTags on all EditExistingCaseScreen elements (6063f32)
  • feat(designsystem): add testTag on WorkTypeAction in Button.kt (f84023e)
  • feat(caseeditor): add testTags for header and subheader in WorkTypeSummaryView (3b8d864)
  • feat(caseeditor): add testTag on SectionHeader using section index + title (18f74b7)
  • test(e2e): add e2e flow for searching and selecting incident w/ assertions for case view page (84897da)
  • feat(cases): add testTags for actions in CasesFilterScreen (2316228)
  • feat(designsystem): add testTag on CollapsibleIcon with sectionTitle (8e55191)
  • feat(cases): add testTags on all dynamically generated form field in CasesFilterScreen (5667d2d)
  • test(e2e): add e2e flow which checks for change in worksite filters (1b78d75)
  • test(e2e): add more assertions and filters selection cmds to filters-change e2e flow, use env vars for common texts (e043308)
  • feat(caseeditor): set testTag on CircleNumber composable with passed in number (7e3910a)
  • feat(cases): set testTag on FilterButtonBadge with filtersCount (1bffe72)
  • fix(e2e): wait for all worksites to load before selecting filters in filters-change e2e flow (1927502)
  • test(e2e): extend filters-change by applying selected filters & asserting filter changes (40e3840)
  • feat(cases): set dynamic testTag based on incident id on SelectIncidentScreen > IncidentSelectContent (ce8944e)
  • feat(cases): set testTag for filter section header & help row in CasesFilterScreen (9126587)
  • feat(designsystem): add testTag for HelpRow text in HelpDialog (96cb343)
  • feat(app): remove CrisisCleanupAppHeader testTag, add appIncidentSelector testTag (a7f1d63)
  • feat(e2e): improve incident-change e2e flow (25914ea)
  • feat(e2e): improve filter-headers e2e flow (d9ff453)
  • feat(e2e) improve incident-search-invalid e2e flow by using testTags (cb19a57)
  • feat(e2e): make improvements to incident-selector e2e flow by using testTags (22222f0)
  • feat(caseeditor): add testTags for SaveActionBar under CaseEditorScreen (b339377)
  • feat(caseeditor): set testTags in PropertyDataScreen (ef4712e)
  • feat(caseeditor): add testTags on PropertyLocationViews (cbf21b6)
  • feat(caseeditor): add testTag for GoogleMap view under LocationScreen (99c12c5)
  • feat(designsystem): add testTags for OpenSettingsDialog in ExplainLocationPermissionDialog (9c0d1a2)

Screenshots

N/A

Related Issue

Ref: #50, #52

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Does this introduce a breaking change?

  • Yes
  • No

…tionBarItem` as it generates invalid testTag
…change e2e flow, use env vars for common texts
@deepanchal deepanchal changed the title feat: More E2e tests, test improvements, add more testTags feat: More E2e tests, test improvements, add more testTags (pt. 2) Aug 17, 2023
@hueachilles hueachilles merged commit da03bfb into main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants