Skip to content

Commit

Permalink
Update font on dropdown items
Browse files Browse the repository at this point in the history
  • Loading branch information
hueachilles committed Jul 27, 2023
1 parent 4c26f19 commit 702fbe0
Show file tree
Hide file tree
Showing 9 changed files with 45 additions and 13 deletions.
2 changes: 1 addition & 1 deletion app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ plugins {

android {
defaultConfig {
val buildVersion = 117
val buildVersion = 118
applicationId = "com.crisiscleanup"
versionCode = buildVersion
versionName = "0.1.${buildVersion - 100}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@ import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.lazy.LazyListScope
import androidx.compose.foundation.lazy.items
import androidx.compose.material3.DropdownMenuItem
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.asImageBitmap
import com.crisiscleanup.core.common.combineTrimText
import com.crisiscleanup.core.commoncase.model.CaseSummaryResult
import com.crisiscleanup.core.designsystem.theme.LocalFontStyles
import com.crisiscleanup.core.designsystem.theme.listItemOptionPadding
import com.crisiscleanup.core.designsystem.theme.listRowItemStartPadding
import com.crisiscleanup.core.designsystem.theme.optionItemPadding
Expand All @@ -41,8 +43,14 @@ private fun CaseView(
.listRowItemStartPadding()
) {
with(summary) {
Text(listOf(name, caseNumber).combineTrimText())
Text(listOf(address, city, state).combineTrimText())
Text(
listOf(name, caseNumber).combineTrimText(),
style = LocalFontStyles.current.header4,
)
Text(
listOf(address, city, state).combineTrimText(),
style = MaterialTheme.typography.bodyLarge,
)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import com.crisiscleanup.core.designsystem.component.CrisisCleanupTextCheckbox
import com.crisiscleanup.core.designsystem.component.HelpAction
import com.crisiscleanup.core.designsystem.component.OutlinedClearableTextField
import com.crisiscleanup.core.designsystem.icon.CrisisCleanupIcons
import com.crisiscleanup.core.designsystem.theme.LocalFontStyles
import com.crisiscleanup.core.designsystem.theme.centerAlignTextFieldLabelOffset
import com.crisiscleanup.core.designsystem.theme.disabledAlpha
import com.crisiscleanup.core.designsystem.theme.listCheckboxAlignStartOffset
Expand Down Expand Up @@ -434,14 +435,24 @@ private fun DropdownItems(
) {
DropdownMenuItem(
modifier = Modifier.optionItemHeight(),
text = { Text("") },
text = {
Text(
"",
style = LocalFontStyles.current.header4,
)
},
onClick = { onSelect("") },
)
for (option in options) {
key(option.key) {
DropdownMenuItem(
modifier = Modifier.optionItemHeight(),
text = { Text(option.value) },
text = {
Text(
option.value,
style = LocalFontStyles.current.header4,
)
},
onClick = { onSelect(option.key) },
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import com.crisiscleanup.core.designsystem.component.CrisisCleanupRadioButton
import com.crisiscleanup.core.designsystem.component.HelpRow
import com.crisiscleanup.core.designsystem.component.OutlinedClearableTextField
import com.crisiscleanup.core.designsystem.component.WithHelpDialog
import com.crisiscleanup.core.designsystem.theme.LocalFontStyles
import com.crisiscleanup.core.designsystem.theme.listItemDropdownMenuOffset
import com.crisiscleanup.core.designsystem.theme.listItemHeight
import com.crisiscleanup.core.designsystem.theme.listItemHorizontalPadding
Expand Down Expand Up @@ -211,10 +212,9 @@ private fun PropertyFormResidentNameView(
DropdownMenuItem(
text = {
Text(
LocalAppTranslator.current(
"actions.stop_searching_cases",
),
LocalAppTranslator.current("actions.stop_searching_cases"),
modifier = Modifier.offset(x = 12.dp),
style = LocalFontStyles.current.header4,
)
},
onClick = onStopSuggestions,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ import com.crisiscleanup.core.designsystem.component.OutlinedClearableTextField
import com.crisiscleanup.core.designsystem.component.TopAppBarCancelAction
import com.crisiscleanup.core.designsystem.component.cancelButtonColors
import com.crisiscleanup.core.designsystem.icon.CrisisCleanupIcons
import com.crisiscleanup.core.designsystem.theme.LocalFontStyles
import com.crisiscleanup.core.designsystem.theme.disabledAlpha
import com.crisiscleanup.core.designsystem.theme.listCheckboxAlignStartOffset
import com.crisiscleanup.core.designsystem.theme.listItemDropdownMenuOffset
Expand Down Expand Up @@ -486,6 +487,7 @@ private fun LazyListScope.contactSuggestionsItem(
Text(
"${contact.name}\n${contact.contactValue}",
Modifier.optionItemPadding(),
style = LocalFontStyles.current.header4,
)
},
onClick = { viewModel.onAddContact(contact) },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import com.crisiscleanup.core.designsystem.LocalAppTranslator
import com.crisiscleanup.core.designsystem.component.AnimatedBusyIndicator
import com.crisiscleanup.core.designsystem.component.TopAppBarCancelAction
import com.crisiscleanup.core.designsystem.icon.CrisisCleanupIcons
import com.crisiscleanup.core.designsystem.theme.LocalFontStyles
import com.crisiscleanup.core.designsystem.theme.listItemHorizontalPadding
import com.crisiscleanup.core.designsystem.theme.listItemModifier
import com.crisiscleanup.core.designsystem.theme.listItemPadding
Expand Down Expand Up @@ -208,7 +209,12 @@ private fun FlagsDropdown(
key(option.literal) {
DropdownMenuItem(
modifier = Modifier.optionItemHeight(),
text = { Text(translator(option.literal)) },
text = {
Text(
translator(option.literal),
style = LocalFontStyles.current.header4,
)
},
onClick = {
onSelectedFlagFlow(option)
showDropdown = false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import com.crisiscleanup.core.designsystem.LocalAppTranslator
import com.crisiscleanup.core.designsystem.component.CrisisCleanupRadioButton
import com.crisiscleanup.core.designsystem.component.CrisisCleanupTextArea
import com.crisiscleanup.core.designsystem.component.OutlinedClearableTextField
import com.crisiscleanup.core.designsystem.theme.LocalFontStyles
import com.crisiscleanup.core.designsystem.theme.listItemDropdownMenuOffset
import com.crisiscleanup.core.designsystem.theme.listItemHeight
import com.crisiscleanup.core.designsystem.theme.listItemModifier
Expand Down Expand Up @@ -167,6 +168,7 @@ internal fun ColumnScope.UpsetClientFlagView(
Text(
organization.name,
Modifier.optionItemPadding(),
style = LocalFontStyles.current.header4,
)
},
onClick = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import com.crisiscleanup.core.designsystem.LocalAppTranslator
import com.crisiscleanup.core.designsystem.component.AnimatedBusyIndicator
import com.crisiscleanup.core.designsystem.component.CrisisCleanupTextCheckbox
import com.crisiscleanup.core.designsystem.component.OutlinedClearableTextField
import com.crisiscleanup.core.designsystem.theme.LocalFontStyles
import com.crisiscleanup.core.designsystem.theme.listItemDropdownMenuOffset
import com.crisiscleanup.core.designsystem.theme.listItemModifier
import com.crisiscleanup.core.designsystem.theme.listItemSpacedBy
Expand Down Expand Up @@ -150,6 +151,7 @@ internal fun ColumnScope.WrongIncidentFlagView(
Text(
incident.name,
Modifier.optionItemPadding(),
style = LocalFontStyles.current.header4,
)
},
onClick = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import androidx.compose.foundation.shape.CircleShape
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.DropdownMenu
import androidx.compose.material3.DropdownMenuItem
import androidx.compose.material3.FloatingActionButton
import androidx.compose.material3.Icon
import androidx.compose.material3.LinearProgressIndicator
import androidx.compose.material3.LocalContentColor
Expand Down Expand Up @@ -573,7 +572,7 @@ private fun CasesOverlayElements(
) = createRefs()

if (isMapView) {
FloatingActionButton(
CrisisCleanupFab(
modifier = modifier
.constrainAs(disasterAction) {
start.linkTo(parent.start, margin = actionEdgeSpace)
Expand All @@ -583,6 +582,8 @@ private fun CasesOverlayElements(
shape = CircleShape,
containerColor = incidentDisasterContainerColor,
contentColor = incidentDisasterContentColor,
// TODO Disable when no incidents are available
enabled = true,
) {
Icon(
painter = painterResource(disasterResId),
Expand Down Expand Up @@ -617,7 +618,7 @@ private fun CasesOverlayElements(
},
)

FloatingActionButton(
CrisisCleanupFab(
modifier = modifier
.actionSize()
.constrainAs(myLocation) {
Expand All @@ -626,6 +627,7 @@ private fun CasesOverlayElements(
},
onClick = centerOnMyLocation,
shape = actionRoundCornerShape,
enabled = true,
) {
Icon(
painterResource(R.drawable.ic_my_location),
Expand Down Expand Up @@ -713,7 +715,6 @@ private fun CasesCountView(
),
color = Color.White,
textAlign = TextAlign.Center,
style = MaterialTheme.typography.bodyMedium,
)
}
}
Expand Down

0 comments on commit 702fbe0

Please sign in to comment.