Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Support for {id:"", src:""} Format... #318

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from

Conversation

probityrules
Copy link

This fixes a few issues with the {src: "path/to/file", id: "audioId"} format for both sound registration and sound removal:

  1. registerSounds passes the id to registerSound for each entry if it's defined.
  2. Registration accepts src property in a hash.
  3. Registration correctly accepts file-types in hash (parameter/variable name mismatch).
  4. Sound removal accepts {id: "audioId"} format to mirror sound registration, like SoundJS v1.
  5. Put in a rejection analogous to _fetchByUrlArray for _fetchByUrlHash since it appeared to be missing.

…}` format for both sound registration and sound removal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant