CASMINST-6522: Remove now-unnecessary CSM 1.4-style iPXE pod test #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharding-hpe
force-pushed
the
CASMINST-6522
branch
from
0b0d947 to
4a25720
Compare
mharding-hpe
requested review from
bo-quan,
kimjensen-hpe,
ndavidson-hpe,
spillerc-hpe and
leliasen-hpe
ndavidson-hpe
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CSM 1.5, we had to split the iPXE pod test into two different tests, because there were changes to the iPXE deployment in that release. One test was run during upgrades, when CSM 1.4 was installed. And the other test was run in all other cases.
In the CSM 1.6 release, we will never be in a situation during an upgrade when CSM 1.4 is still running on the system. Thus, this PR removes the CSM 1.4-style test, and updates the relevant test suite to use the regular iPXE test.