CASMINST-6819: external-dns-resolver test improvements/fixes #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharding-hpe
force-pushed
the
CASMINST-6819-1.6
branch
from
ceb5174 to
41b8b55
Compare
|
/backport release/1.5 release/1.4 |
|
Backporting into branch release/1.5 was successful. New PR: #581 |
|
Backporting into branch release/1.4 was successful. New PR: #582 |
…st output; make test able to handle systems with multiple LDAP servers
mharding-hpe
force-pushed
the
CASMINST-6819-1.6
branch
from
41b8b55 to
5080e10
Compare
mharding-hpe
requested review from
bo-quan,
kimjensen-hpe,
leliasen-hpe and
ndavidson-hpe
kimjensen-hpe
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
goss-k8s-resolve-external-dnstest currently fails on systems which have multiple LDAP servers configured (for example, all of the UKMet customer systems). In addition, it does not log its output. This PR does five things:I have tested the updated script on both internal systems and UKMet, and it works fine. I tested it both standalone and by running the updated Goss test.
Backports:
#581
#582