Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_bios_firmware_versions.sh script for new versions CASMTRIAGE-6647 #568

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

mbuchmann-hpe
Copy link
Contributor

Summary and Scope

Update to the check_bios_firmware_versions.sh script for updated values for CSM 1.5 release and documentation link

Issues and Related PRs

Risks and Mitigations

Just updated version numbers to the latest released in the CSM 1.5 firmware package.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@mbuchmann-hpe mbuchmann-hpe requested a review from a team as a code owner March 12, 2024 21:00
Copy link
Contributor

@jacobsalmela jacobsalmela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so sad this script is still here, but it looks like it will still do the job

@jwlv jwlv self-requested a review March 12, 2024 21:30
Copy link
Contributor

@jacobsalmela jacobsalmela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are fine. Shellcheck is failing on other scripts for some reason. Also needs a rebase to get up-to-date.

@kimjensen-hpe
Copy link
Contributor

/backport release/1.6

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Backporting into branch release/1.6 was successful. New PR: #575

@kimjensen-hpe kimjensen-hpe merged commit d7f9729 into release/1.5 Apr 1, 2024
3 checks passed
@kimjensen-hpe kimjensen-hpe deleted the ChkFirmware_1.5 branch April 1, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants