CASMPET-6819: Create Goss Test Suite for SPBS

[aasha-hpe]

Summary and Scope

This is goss test suite written newly for iscsi based boot content projection solution.

Testing

Tested on Mug and Noname systems. Will test on CSM 1.5 once it is installed.

Tested on:

Tested on Mug and Noname.

Test description:

The new test cases written for iscsi based boot content projection and added to CSM goss testing framework This get invoked as part of CSM health checks post OS and CSM services are installed.

• Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? yet to run in upgrade scenario
• Were continuous integration tests run? If not, why?
• Was upgrade tested? If not, why?- TBD when system is available.
• Was downgrade tested? If not, why?
• Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations

None.

Pull Request Checklist

• Version number(s) incremented, if applicable
• Copyrights updated
• License file intact
• Target branch correct
• CHANGELOG.md updated
• Testing is appropriate and complete, if applicable
• HPC Product Announcement prepared, if applicable

[jeremy-duckworth]

@aasha-hpe is this ready for review? Thanks.

[jeremy-duckworth]

Please address the shell-check warnings and follow up on the K8S worker labels.

[aasha-hpe]

@aasha-hpe is this ready for review? Thanks.

@jeremy-duckworth Yes. This was ready for review.

[aasha-hpe]

Please address the shell-check warnings and follow up on the K8S worker labels.

There were some shell check errors which I fixed, thought we can ignore the warnings. Can we ? We have done this way of implementation in Mercury, we never faced shell-check errors nor any issues with the code.
@jeremy-duckworth, I have taken care of shellcheck warnings. Pls take a look.

[aasha-hpe]

Please address the shell-check warnings and follow up on the K8S worker labels.

@jeremy-duckworth, Have taken care of shell-check warnings and K8s worker labels. Now the label is 'iscsi=sbps'. Pls take a look.

[aasha-hpe]

Please address the shell-check warnings and follow up on the K8S worker labels.

There were some shell check errors which I fixed, thought we can ignore the warnings. Can we ? We have done this way of implementation in Mercury, we never faced shell-check errors nor any issues with the code.

@jeremy-duckworth, I have taken care of shellcheck warnings. Pls take a look.

[jeremy-duckworth]

Approved with suggestions

[aasha-hpe]

@dborman-hpe, Thanks a lot for your review and comments. I have addressed them. Please take a look.

[aasha-hpe]

I incorporated the changes and tested. Its working fine.

[dborman-hpe]

Please fix the shellcheck warnings:

[HPE-C02XJ1WHJGH6] shellcheck iscsi_sbps_sanity.sh 

In iscsi_sbps_sanity.sh line 129:
for s in $(dig -t srv +short _sbps-hsn._tcp."${host}" | sort -k3 | awk '{print $NF;}' | xargs); do printf "** $s **\n"; dig +short $s; done
                                                                                                          ^----------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
                                                                                                                                   ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
for s in $(dig -t srv +short _sbps-hsn._tcp."${host}" | sort -k3 | awk '{print $NF;}' | xargs); do printf "** $s **\n"; dig +short "$s"; done


In iscsi_sbps_sanity.sh line 131:
for s in $(dig -t srv +short _sbps-nmn._tcp."${host}" | sort -k3 | awk '{print $NF;}' | xargs); do printf "** $s **\n"; dig +short $s; done
                                                                                                          ^----------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
                                                                                                                                   ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
for s in $(dig -t srv +short _sbps-nmn._tcp."${host}" | sort -k3 | awk '{print $NF;}' | xargs); do printf "** $s **\n"; dig +short "$s"; done

For more information:
  https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

[aasha-hpe]

Please fix the shellcheck warnings:

[HPE-C02XJ1WHJGH6] shellcheck iscsi_sbps_sanity.sh 

In iscsi_sbps_sanity.sh line 129:
for s in $(dig -t srv +short _sbps-hsn._tcp."${host}" | sort -k3 | awk '{print $NF;}' | xargs); do printf "** $s **\n"; dig +short $s; done
                                                                                                          ^----------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
                                                                                                                                   ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
for s in $(dig -t srv +short _sbps-hsn._tcp."${host}" | sort -k3 | awk '{print $NF;}' | xargs); do printf "** $s **\n"; dig +short "$s"; done


In iscsi_sbps_sanity.sh line 131:
for s in $(dig -t srv +short _sbps-nmn._tcp."${host}" | sort -k3 | awk '{print $NF;}' | xargs); do printf "** $s **\n"; dig +short $s; done
                                                                                                          ^----------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
                                                                                                                                   ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
for s in $(dig -t srv +short _sbps-nmn._tcp."${host}" | sort -k3 | awk '{print $NF;}' | xargs); do printf "** $s **\n"; dig +short "$s"; done

For more information:
  https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

Fixed these warnings.

[dborman-hpe]

LGTM