Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
mharding-hpe authored Feb 8, 2024
1 parent a0b1e3f commit 57713cb
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 4 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ dist/
# VS Code config
workspace.code-workspace


# cache specific
*.pyc
**__pycache__**
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [2.0.0] - 2024-01-16
## [2.0.0] - 2024-02-08

### Changed

Expand Down
1 change: 0 additions & 1 deletion charts/cray-product-catalog/templates/configmap-hook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ spec:
yq eval 'del(.metadata.resourceVersion, .metadata.uid, .metadata.annotations, .metadata.creationTimestamp, .metadata.selfLink, .metadata.managedFields)' - |
kubectl create -f -"


---
apiVersion: batch/v1
kind: Job
Expand Down
2 changes: 1 addition & 1 deletion cray_product_catalog/catalog_update.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def create_config_map(api_instance, name, namespace):
LOGGER.info("Created product ConfigMap %s/%s", namespace, name)
return True
except ApiException:
LOGGER.error("Error calling create_namespaced_config_map")
LOGGER.exception("Error calling create_namespaced_config_map")
return False


Expand Down

0 comments on commit 57713cb

Please sign in to comment.