Support --buid-arg for upstream repos #3
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alone will not fully address issue #2. More work is needed to make the liveness python library available externally and to then deprecate the --index-url flags from the requirements.txt files. It's a start though. Use build args like:
docker build -t cfs-operator-test --build-arg BASE_CONTAINER=alpine:3.12.0 --build-arg PIP_INDEX_URL=https://pypi.python.org/simple/ -f Dockerfile .
Keep in mind that in Dockerfiles the ARGS are cleared at each FROM line which is why they are defined multiple times in the same file.