Skip to content

Focus info popup appearing blank #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akarki2005
Copy link
Contributor

@akarki2005 akarki2005 commented Jun 19, 2025

Proposed Changes

This change fixes a bug (issue #1573) causing the focus info popup to be blank.

Before

Currently, clicking on a focus tab does not highlight the relevant courses as it should.

buggyfocusgraph

Also, the info popup for each focus is missing the focus description.

emptyfocus

After

Now, clicking on a focus tab correctly highlights the relevant courses for the focus.

fixedfocusgraph

Additionally, the info popup displays information about the focus.

fixedfocus

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • [N/A] I have updated the project documentation, if applicable.
    • This is required for new features.
  • [N/A] If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9afc334c-2c80-40fc-b2e5-3467d07a0d56

Details

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 32.025%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/Database/CourseQueries.hs 0 9 0.0%
Totals Coverage Status
Change from base Build cbade975-cb65-4f0c-af29-de706cbcd12a: -0.1%
Covered Lines: 640
Relevant Lines: 1924

💛 - Coveralls

@akarki2005 akarki2005 changed the title Focus info popup Focus info popup appearing blank Jun 19, 2025
@akarki2005 akarki2005 marked this pull request as ready for review June 19, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants