Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(codaveri-live-feedback): frontend tweaks #7413

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

adi-herwana-nus
Copy link

@adi-herwana-nus adi-herwana-nus commented Jul 4, 2024

  • tweaked live feedback component styling
  • live feedback drawer now closes only when all feedback is deleted
  • added toast messages for successful feedback / no feedback generated
Screenshot 2024-07-04 at 17 49 25 Screenshot 2024-07-04 at 17 47 10

Copy link
Contributor

@cysjonathan cysjonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Tooltip should not block user from clicking like/dislike/dismiss buttons
    image

  2. Remove horizontal overflow when [Get Help] feedback panel is not rendered
    image

Other than that LGTM.

- tweaked live feedback component styling
- live feedback drawer now closes only when all feedback is deleted
- added toast messages for successful feedback / no feedback generated
- fixed autograded assessment button alignment
@adi-herwana-nus adi-herwana-nus force-pushed the live-feedback-frontend branch from 6877616 to 700aa8c Compare July 5, 2024 08:48
@cysjonathan cysjonathan merged commit 302e6d4 into master Jul 5, 2024
13 checks passed
@cysjonathan cysjonathan deleted the live-feedback-frontend branch July 5, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants