Skip to content

[Journey] Make Journeys drillable #6198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: journey+content-main
Choose a base branch
from
Open

Conversation

John-Weak
Copy link
Contributor

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables drillable journeys by adding new event options for the journey_engine and updating the left sidebar layout in the UI.

  • Updated the left sidebar conditional rendering and tooltip binding using the new "toolTipLeft" prop.
  • Added new event options for the journey_engine in the events helper.
  • Introduced a new prop in the content component to support dynamic tooltip text.

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

File Description
frontend/express/public/javascripts/countly/vue/templates/content/content-body.html Updated left sidebar rendering logic and dynamic tooltip binding for collapsible behavior.
frontend/express/public/javascripts/countly/vue/components/helpers.js Added journey engine event options to support drillable journeys.
frontend/express/public/javascripts/countly/vue/components/content.js Introduced a new "toolTipLeft" prop with default value "Screens" for dynamic tooltip usage.
Files not reviewed (2)
  • frontend/express/public/stylesheets/vue/clyvue.scss: Language not supported
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

frontend/express/public/javascripts/countly/vue/components/helpers.js:717

  • [nitpick] Using the event name "Journey" may be ambiguous compared to other events which follow a consistent naming pattern. Consider aligning it with the project's naming conventions (e.g. "[CLY]_journey").
if (countlyGlobal.plugins.indexOf('journey_engine') !== -1) {

@John-Weak John-Weak changed the base branch from master to journey+content-main May 6, 2025 09:58
@John-Weak John-Weak marked this pull request as ready for review May 20, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants