Merge pull request #5476 from Countly/crash-template

[SER-1743] Fix crashes template paths and add data check
Countly · Aug 28, 2024 · bc4225c · bc4225c
2 parents 6557b1d + 465b564
commit bc4225c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/plugins/crashes/frontend/public/javascripts/countly.views.js b/plugins/crashes/frontend/public/javascripts/countly.views.js
@@ -668,7 +668,7 @@
                 {
                     namespace: "crashes",
                     mapping: {
-                        overview: "crashes/templates/overview.html"
+                        overview: "/crashes/templates/overview.html"
                     }
                 },
                 "/drill/templates/query.builder.v2.html",
@@ -1133,7 +1133,7 @@
                 {
                     namespace: "crashes",
                     mapping: {
-                        crashgroup: "crashes/templates/crashgroup.html"
+                        crashgroup: "/crashes/templates/crashgroup.html"
                     }
                 }
             ]
@@ -1232,7 +1232,7 @@
                 {
                     namespace: "crashes",
                     mapping: {
-                        "binary-images": "crashes/templates/binary-images.html"
+                        "binary-images": "/crashes/templates/binary-images.html"
                     }
                 }
             ]

diff --git a/plugins/crashes/frontend/public/templates/tab-label.html b/plugins/crashes/frontend/public/templates/tab-label.html
@@ -6,7 +6,7 @@
         </div>
     </div>
     <div class="bu-is-flex bu-is-align-items-center">
-        <h2 v-if="data.isEstimate" v-tooltip="i18n('common.estimation')" class="is-estimate" :data-test-id="`cly-section-${title.toLowerCase().replaceAll(/\s/g, '-').replace('/', 'or')}-value`">
+        <h2 v-if="data && data.isEstimate" v-tooltip="i18n('common.estimation')" class="is-estimate" :data-test-id="`cly-section-${title.toLowerCase().replaceAll(/\s/g, '-').replace('/', 'or')}-value`">
             ~{{ data && data.total && !isNaN(data.total) && getShortNumber(data.total) || data && data.total}}
         </h2>
         <h2 v-else :data-test-id="`cly-section-${title.toLowerCase().replaceAll(/\s/g, '-').replace('/', 'or')}-value`">
@@ -22,4 +22,4 @@ <h2 v-else :data-test-id="`cly-section-${title.toLowerCase().replaceAll(/\s/g, '
             <i class="cly-trend-neutral-icon ion-minus-round bu-ml-2" :data-test-id="`cly-section-${title.toLowerCase().replaceAll(/\s/g, '-').replace('/', 'or')}-arrow`"></i><span :data-test-id="`cly-section-${title.toLowerCase().replaceAll(/\s/g, '-').replace('/', 'or')}-change-value`">{{data && data.change}}</span>
         </div>
     </div>
-</div>
+</div>