Add support for fts inside extension #400
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -357,6 +357,18 @@ | |||
| "SQL++" | |||
| ], | |||
| "configuration": "./language/language-configuration.json" | |||
| }, | |||
|
|
|||
There was a problem hiding this comment.
Please remove extra space in package.json
| "SEARCH" | ||
| ], | ||
| "configuration": "./language/language-configuration.json" | ||
|
|
| "command": "vscode-couchbase.runSearch", | ||
| "key": "ctrl+shift+e", | ||
| "mac": "cmd+shift+e", | ||
| "when": "(editorLangId == cbs.json || resourceFilename =~ /.cbs.json$/) && !isKVCluster" |
There was a problem hiding this comment.
We will have to add another condition stating isSearchService. Because by default, search service is not mandatory
There was a problem hiding this comment.
The 2 icons are very different
Comment on lines
+19
to
+23
| if (result?.indexDef instanceof Uint8Array || result?.indexDef instanceof Uint16Array || result?.indexDef instanceof Uint32Array) { | ||
| vscode.window.showInformationMessage("Unable to open Index definition: It is not a valid JSON", { modal: true }); | ||
| return false; | ||
| } | ||
| const uri = vscode.Uri.parse( |
There was a problem hiding this comment.
is this the correct way of confirming it is valid json file?
Comment on lines
+36
to
+37
| vscode.window.showInformationMessage("Unable to open Index definition: It is not a valid JSON ", { modal: true }); | ||
| return false; |
There was a problem hiding this comment.
Print error message as well, so that detailed debugging is possible here. Use logger.error for that
Comment on lines
+700
to
+720
| const openSearchWorkbenchCommand = vscode.commands.registerCommand(Commands.openSearchWorkbench, async (searchIndexNode: SearchIndexNode) => { | ||
| const connection = Memory.state.get<IConnection>(Constants.ACTIVE_CONNECTION); | ||
| if (!connection) { | ||
| vscode.window.showErrorMessage("No active connection available."); | ||
| return; | ||
| } | ||
|
|
||
| currentSearchIndexNode = searchIndexNode; | ||
| currentSearchWorkbench = searchWorkbench; | ||
|
|
||
| searchWorkbench.openSearchWorkbench(searchIndexNode, memFs); | ||
|
|
||
| const editorChangeSubscription = vscode.window.onDidChangeActiveTextEditor(async (editor) => { | ||
| if (editor && editor.document.languageId === "searchQuery") { | ||
| await handleSearchContextStatusbar(editor, searchIndexNode, searchWorkbench, globalStatusBarItem); | ||
| } | ||
| }); | ||
| context.subscriptions.push(editorChangeSubscription); | ||
|
|
||
| }); | ||
| context.subscriptions.push(openSearchWorkbenchCommand); |
There was a problem hiding this comment.
Can we shift this to a new file?
Comment on lines
+53
to
+54
| if (!hasQueryService(connection?.services) || filterDocumentsType !== "query") { | ||
| rowCount = KVCollectionCount.get(`kv_collection_item_count-${this.bucketName}-${this.scopeName}-${collection.name}`) ?? 0; |
There was a problem hiding this comment.
Will need to check for search service as well wherever required
Comment on lines
+44
to
+64
| // get all search indexes | ||
| const connection = getActiveConnection(); | ||
| if (!connection){ | ||
|
|
||
| return [] | ||
| } | ||
| const searchIndexesManager = connection?.cluster?.searchIndexes(); | ||
| const ftsIndexes = await searchIndexesManager?.getAllIndexes(); | ||
| const bucketIndexes = ftsIndexes?.filter(index => index.sourceName === this.bucketName); | ||
| if (bucketIndexes === undefined) { | ||
| return []; | ||
| } | ||
| const searchIndexChildren: INode[] = bucketIndexes.map((searchIndex) => | ||
| new SearchIndexNode( | ||
| searchIndex.name, | ||
| this.bucketName, | ||
| this.scopeName, | ||
| searchIndex.name | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
Based on search service present, Otherwise you may show an information node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.