Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Misha's commit for GCImpl #2853

Closed
wants to merge 2 commits into from
Closed

Revert Misha's commit for GCImpl #2853

wants to merge 2 commits into from

Conversation

RaphProductions
Copy link
Contributor

The commit made by Misha 2 weeks ago broke the 'Cosmos.Core.Memory.Heap.Collect()' function. This commit aims to revert these changes

The commit made by Misha 2 weeks ago broke the 'Cosmos.Core.Memory.Heap.Collect()' function. This commit aims to revert these changes
@valentinbreiz
Copy link
Member

What did it broke? It seems to work for me

@RaphProductions
Copy link
Contributor Author

Heap.Collect

@RaphProductions
Copy link
Contributor Author

When i tried Mirage with the latest commit, it froze on the setup screen.

@GoldenretriverYT
Copy link
Contributor

Yeah there are some issues with Heap.Collect on the latest commit, but were you able to actually verify that it was that commit? Just because it changed the GC code doesn't meant it has to be that commit, so please make sure it was actually this commit.

@RaphProductions
Copy link
Contributor Author

I reverted back the GCimpl code on my local version, and it works again

@ADev531
Copy link

ADev531 commented Dec 22, 2023

it, works for me and i can use gui os over than 10 minutes

@9xbt
Copy link
Contributor

9xbt commented Dec 23, 2023

don't blame misha, it's just that the gc is shit but i mean if you optimize your os which i really did with mango it will run just fine, no fps drop

@RaphProductions
Copy link
Contributor Author

don't blame misha, it's just that the gc is shit but i mean if you optimize your os which i really did with mango it will run just fine, no fps drop

I didn't blame Misha, they are doing really good work, but Heap.Collect now crashes the OS

@RaphProductions
Copy link
Contributor Author

I mean, everyone can break everything

@quajak
Copy link
Member

quajak commented Jan 1, 2024

We might need to readd some code like the original one to prevent the heap from being on top of kernel code. But I think we removed this code to fix #2546. Therefore, we should try find a solution which fixes both issues, rather than just reintroduce the old one

@pleasenoban
Copy link
Contributor

i dont think this stops it from overriding the acpi tables though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants