-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Misha's commit for GCImpl #2853
Conversation
The commit made by Misha 2 weeks ago broke the 'Cosmos.Core.Memory.Heap.Collect()' function. This commit aims to revert these changes
What did it broke? It seems to work for me |
Heap.Collect |
When i tried Mirage with the latest commit, it froze on the setup screen. |
Yeah there are some issues with Heap.Collect on the latest commit, but were you able to actually verify that it was that commit? Just because it changed the GC code doesn't meant it has to be that commit, so please make sure it was actually this commit. |
I reverted back the GCimpl code on my local version, and it works again |
it, works for me and i can use gui os over than 10 minutes |
don't blame misha, it's just that the gc is shit but i mean if you optimize your os which i really did with mango it will run just fine, no fps drop |
I didn't blame Misha, they are doing really good work, but Heap.Collect now crashes the OS |
I mean, everyone can break everything |
We might need to readd some code like the original one to prevent the heap from being on top of kernel code. But I think we removed this code to fix #2546. Therefore, we should try find a solution which fixes both issues, rather than just reintroduce the old one |
i dont think this stops it from overriding the acpi tables though? |
The commit made by Misha 2 weeks ago broke the 'Cosmos.Core.Memory.Heap.Collect()' function. This commit aims to revert these changes