Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: golang-ci-lint-action #974

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 1, 2024

Basically, start with stuff that's easy.

  • Bump golangci/golangci-lint-action from 3 to 4
  • update lint action
  • do the easy stuff first....

replaces #966

dependabot bot and others added 3 commits February 12, 2024 02:08
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3...v4)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@faddat
Copy link
Contributor Author

faddat commented Mar 1, 2024

ah, interchaintest is flaky like normal

why have unreliable tests?

Copy link
Member

@dimiandre dimiandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dimiandre
Copy link
Member

tests are now passing

@dimiandre dimiandre merged commit 3733476 into CosmosContracts:main Mar 2, 2024
22 checks passed
dimiandre pushed a commit that referenced this pull request Mar 2, 2024
* Bump golangci/golangci-lint-action from 3 to 4

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3...v4)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* update lint action

* do the easy stuff first....

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dimiandre added a commit that referenced this pull request Mar 2, 2024
* fix! not loading in contracts with custom WasmVM after upgrade (#961)

* fix!: load from the proper data dir

* v20 plain upgrade

* lintor

* execute contract's before and after an upgrade

* remove v20 storekey addition

* CreateV20UpgradeHandler

* remove v20

* fix upgrade test (v18 -> v19)

* Create v21 Namespace & Upgrade Handler

* bump: golang-ci-lint-action (#974)

* Bump golangci/golangci-lint-action from 3 to 4

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3...v4)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* update lint action

* do the easy stuff first....

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* run upgrade test against v20 & remove wasm from store upgrades

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: Jacob Gadikian <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrea Di Michele <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants