Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v19: Enforce Validator's Max 24 Hour Change Rate To 5% #875

Merged
merged 18 commits into from
Dec 12, 2023
Merged

v19: Enforce Validator's Max 24 Hour Change Rate To 5% #875

merged 18 commits into from
Dec 12, 2023

Conversation

joelsmith-2019
Copy link
Contributor

@joelsmith-2019 joelsmith-2019 commented Oct 28, 2023 •
edited
Loading

Closes #819

  • Create ante handler
  • Unit testing (Standard Messages)
  • Ensure Authz inline messages are filtered
  • Unit testing Authz messages
  • Convert all validators to 5% max change in the v19 upgrade handler per proposal 316

@joelsmith-2019 joelsmith-2019 self-assigned this Oct 28, 2023
@Reecepbcups
Copy link
Contributor

I wrote some Ante example test here in another repo: https://github.com/strangelove-ventures/poa/blob/399274a6c80a595f539826ff25ea64482774ef2a/ante/ante_test.go

the setBlockHeader(...) func could be modified with a set time as well. or just increase it 50k blocks every unit test

@Reecepbcups Reecepbcups changed the title Enforce Validator's Max 24 Hour Change Rate To 5% v19: Enforce Validator's Max 24 Hour Change Rate To 5% Nov 10, 2023
@Reecepbcups
Copy link
Contributor

Reecepbcups commented Nov 22, 2023 •
edited
Loading

This is going to continue as planned to v19 since it requires an Upgrade Handler to

  • iter all validators
  • grab validator
  • update val info MaxCommissionRate = 0.05
  • save val

Blocked until v18 is on mainnet & I ship v19 namespace

@Reecepbcups Reecepbcups added the blocked We can't do this until something else is done label Nov 22, 2023
@Reecepbcups Reecepbcups removed the blocked We can't do this until something else is done label Dec 11, 2023
@Reecepbcups
Copy link
Contributor

This can be resumed once #906 gets in

@joelsmith-2019 joelsmith-2019 added the review me Review me for merge label Dec 12, 2023
@joelsmith-2019 joelsmith-2019 marked this pull request as ready for review December 12, 2023 01:42
@Reecepbcups Reecepbcups enabled auto-merge (squash) December 12, 2023 01:53
@Reecepbcups Reecepbcups removed the review me Review me for merge label Dec 12, 2023
@Reecepbcups Reecepbcups merged commit 68e08e7 into main Dec 12, 2023
7 checks passed
@joelsmith-2019 joelsmith-2019 deleted the joel/max-change-rate branch February 2, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reecepbcups Reecepbcups Reecepbcups approved these changes

@the-frey the-frey Awaiting requested review from the-frey

@JakeHartnell JakeHartnell Awaiting requested review from JakeHartnell JakeHartnell is a code owner

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@dimiandre dimiandre Awaiting requested review from dimiandre dimiandre is a code owner

Assignees

@joelsmith-2019 joelsmith-2019

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prop 316: Update Validator's Max 24 Hour Change Rate To 5%
2 participants
@joelsmith-2019 @Reecepbcups