Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass signature verification for testing #849

Closed
wants to merge 2 commits into from

Conversation

Reecepbcups
Copy link
Contributor

@Reecepbcups Reecepbcups commented Oct 4, 2023

Good use case would be for example, interchaintest.

Take mainnet state in (simulate a whale) and perform actions on their behalf locally against what would actually happen & with the accounts which would be interacting.

@Reecepbcups Reecepbcups changed the title DNM: bypass signature verification Bypass signature verification for testing Oct 5, 2023
@Reecepbcups Reecepbcups marked this pull request as ready for review October 5, 2023 19:03
Copy link
Member

@dimiandre dimiandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem very safe to me, it opens more weak spots on the node for a coordinated attack. Maybe better to keep it in a separate tag/branch

@Reecepbcups
Copy link
Contributor Author

@dimiandre it would still require 51% of the VP to be compromised to run this attack. I see it as the same security risk as using Cosmovisor would be, no?

@dimiandre
Copy link
Member

@dimiandre it would still require 51% of the VP to be compromised to run this attack. I see it as the same security risk as using Cosmovisor would be, no?

Cosmovisor is not installed by default, this is an option available to anyone and a simple os env var can activate it. Os vars can be very easily manipulated by any external software.

Also i think with just 33% of the vp this can cause a chain halt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants