-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v18] Juno x/burn module #801
Conversation
This way the query "juno q bank total" will be wrong and It's used by many third party services. I'm not sure if this is the proper way to do it. Probably better to keep the standard burn functions and modify our mint module so that it's also reduced in minter.TargetSupply |
* reduce tokens in targetsupply when burning * lint --------- Co-authored-by: Reece Williams <[email protected]>
TODO: Voting yes on the Unity contract continues to fail for not passing vote. Very odd its effecting SudoContracts |
@Reecepbcups I pushed a new commit. The burning was not working before because coins were sent to x/junoburn module but burn was happening on x/wasm My commit:
This can be tested using docker and test contract in this repository https://github.com/dimiandre/cw-testburn/blob/39d44cc74911d34a369ed1d9af0af07efaefd982/contracts/first-contract/src/contract.rs#L50
|
… test the actual interaction)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
great job with contract refactor and tests!
Closes #647
Files of importance
Usage
There are 2 ways to burn tokens
juno1mj7t69y4r2adl3cnuq8y9uundkzawvx6avu7nj
TODO