feat:update findex #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HatemMn
commented
Nov 14, 2024
HatemMn
force-pushed
the
feat/encrypt_findex_db
branch
from
fe2cee2 to
bb0b148
Compare
HatemMn
commented
Nov 18, 2024
HatemMn
commented
Nov 18, 2024
ccorsin
reviewed
Nov 18, 2024
src/utils/covercryptConfig.ts
Outdated
| @@ -9,6 +9,18 @@ export type Employee = { | |||
| salary?: number | string; | |||
| }; | |||
|
|
|||
| // in the findex workflow we need to have the country as a string because it will be encrypted | |||
| // using this new type to avoid breaking changes (OCP) | |||
| export type findexDatabaseEmployee = Omit<Employee, "country"> & { country?: string }; | |||
There was a problem hiding this comment.
wrong naming - encryptedEmployee
There was a problem hiding this comment.
Are you sure ? I can't see it
HatemMn
commented
Nov 20, 2024
There was a problem hiding this comment.
General thoughts :
Those files under public/actions
They should have never been committed to the repo, they should be copied in Vite's config at build time and be ignored when committing
I will add this to one of the repo issues to update it, it should make reviews less verbose for us and avoid linters & co catching those files
src/utils/covercryptConfig.ts
Outdated
| @@ -9,6 +9,18 @@ export type Employee = { | |||
| salary?: number | string; | |||
| }; | |||
|
|
|||
| // in the findex workflow we need to have the country as a string because it will be encrypted | |||
| // using this new type to avoid breaking changes (OCP) | |||
| export type findexDatabaseEmployee = Omit<Employee, "country"> & { country?: string }; | |||
HatemMn
force-pushed
the
feat/encrypt_findex_db
branch
from
53d4b0e to
03d5b0d
Compare
ccorsin
reviewed
Nov 21, 2024
ccorsin
approved these changes
Nov 21, 2024
chore:WIP save feat:first working prototype feat: encrypt db OK feat: first working app fix: fix encrypt DB bugs
fix:rebase
fix: restaure knip fix: restaure package-lock
fix:final review fixes reread fix:another fix chore:lint the project fix:fix cloudproof bug, upgrade lock feat:commit login logo chore:fix store
HatemMn
force-pushed
the
feat/encrypt_findex_db
branch
from
2504939 to
a324212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new ?
[ ] ded codemoved here : Dead code #36 . specefic PR will be created laterGeneral notes
might see multiple such copy pasted lines like this :
'refactoring' these needs a lot of code lines ( ~ 25 ) and generates (pointless) type errors that need themselves other boilerplate. I consider the upper code to be way more readable, despite "the copy". Any less verbose suggestion is welcome !