Bindings python #65

ackRow · 2022-11-09T08:39:29Z

Features

New python interfaces based on objects rather than functions
Unit tests for the python lib
CI: automatic building, testing and publishing

Technical choices

Compatibility with manylinux glibc >= 2.17 and Python >= 3.7
Manylinux
Abi3

Limitations

No build pipeline for Windows/MacOS yet
Doc string exported but not the functions signature

Porting code from 'cloudproof_python'

Check for successful decryption after refreshing the user key. Update InsufficientAccessPolicy error message to be more accurate.

tbrezot

Very nice! Some changes to be made on error conversion.

Also, you may want to implement your wrappers that way:

struct Attribute(AttributeRust);

This is less noisy then:

pub fn new(axis: &str, name: &str) -> Self {
    Self(AttributeRust::new(axis, name))
}

.gitlab-ci.yml

CHANGELOG.md

src/interfaces/pyo3/py_abe_policy.rs

src/interfaces/pyo3/py_cover_crypt.rs

src/interfaces/pyo3/py_abe_policy.rs

Co-authored-by: Théophile BRÉZOT <[email protected]>

Manuthor

not much to review, great job! 👍

.gitlab-ci.yml

Cargo.toml

pyproject.toml

src/interfaces/pyo3/py_abe_policy.rs

src/interfaces/pyo3/py_cover_crypt.rs

src/interfaces/pyo3/tests/test.sh

Co-authored-by: Manuthor <[email protected]>

.gitlab-ci.yml

* new python interfaces based on objects rather than functions covering a broader range of functionalities

* feat: add serialization benchmarks * feat!: initialize `Serializer` with capacity Use the new method `<impl Serializable>::length()` to initialize the `Serializer` in `<impl Serializable>::try_to_bytes()` with the correct capacity. BREAKING CHANGE: do not write the size of the `ciphertext` of the `plaintext` in the serialization of the `EncryptedHeader` and `PlaintextHeader` respectively. * fix: correct the serialized length Check the length in `test_serialization()` * fix: changelog * fix: python interface Serialization was broken in `encrypt()`. * fix: use "develop" branch of CryptoCore * Bindings python (#65) * new python interfaces based on objects rather than functions covering a broader range of functionalities * chore: update version to 8.0.0 * feat: describe serialization in README * Fix/pyo3 (#72) * fix(PyO3): force return of PyBytes instead of PyByteArray * build(PyO3): add windows build * build(PyO3): add python lib build for macOS * refactor(PyO3): factor code in a macro for python keys * refactor(PyO3): set size of key_bytes for SymmetricKey deserialization * build(pyO3): set version for manylinux build and combine python build with ffi when possible * fix(PyO3): change from_bytes function signature * fix(PyO3): change back authentication_data to Vec<u8> to work with python list * refactor(PyO3): add comments * Fix python build (#76) * build: set custom target_dir to solve osx python and flutter conflicts * fix(PyO3): return metadata from decrypt like in the ffi * refactor(PyO3): rewrite conversion to PyBytes to be more explicit * fix(PyO3): apply review suggestions * chore: fix typos and update README.md * fix: revert breaking change in serialization Co-authored-by: Hugo Rosenkranz-Costa <[email protected]> Co-authored-by: Hugo Rosenkranz-Costa <[email protected]> Co-authored-by: Manuthor <[email protected]>

ackRow requested review from bgrieder, Manuthor and tbrezot November 9, 2022 08:39

ackRow changed the base branch from develop to feat/serialize_with_capacity November 9, 2022 12:41

tbrezot and others added 24 commits November 9, 2022 14:18

fix: use "develop" branch of CryptoCore

55f521b

[PyO3] Rewrite to a more object oriented syntax

2998ad7

Porting code from 'cloudproof_python'

[PyO3] Adding user secret key generation

9d1b1f6

[PyO3] Adding encrypt and decrypt (header + symm)

9152727

[PyO3] Adding individual header and symmetric encryption

fc5c35a

[PyO3] Fix fmt

8959e1a

[PyO3] Adding Policy and Encryption tests

6447bd7

[PyO3] Adding header encryption test

bceae2f

[PyO3] Refacto tests

8cbd6fa

edit test_rotate_then_encrypt

4136e01

Check for successful decryption after refreshing the user key. Update InsufficientAccessPolicy error message to be more accurate.

[PyO3] fix rotate test

b2f21aa

[PyO3] testing different serialization/copy method

b082505

[PyO3] feat: add JSON serialization for the Policy python object

f3f4b9d

[PyO3] feat: add byte serialization for keys

071b48e

[PyO3] refactor: split abe_policy and cover_crypt methods

4772999

[PyO3] test: add symmetric key serialization test

a77030d

[PyO3] ci: adding automatic build and test for the python lib

275ac2c

[PyO3] fix: cargo clippy error

4b20158

ci(PyO3): split build and test in 2 different stage

2ca0dc5

ci(PyO3): fix python build

c8e87b0

ci(PyO3): fix maturin image entrypoint

2718665

ci(PyO3): using cache from base_compile for python build

263143d

ci(PyO3): remove base_compile from build_python due to sscache

5c81d71

ci(PyO3): add automatic publishing to Pypi

adb2e1a

ackRow force-pushed the bindings-python branch from 5633265 to adb2e1a Compare November 9, 2022 13:26

tbrezot requested changes Nov 9, 2022

View reviewed changes

tbrezot reviewed Nov 9, 2022

View reviewed changes

src/interfaces/pyo3/py_abe_policy.rs Outdated Show resolved Hide resolved

ackRow and others added 10 commits November 10, 2022 09:52

fix(PyO3): apply suggestions from code review

d87877e

Co-authored-by: Théophile BRÉZOT <[email protected]>

fix(PyO3): change default PyErr to PyException

557fef0

fix(PyO3): use PyErr::from

51b797a

fix(PyO3): update refresh_user_secret_key comment

d498641

Co-authored-by: Théophile BRÉZOT <[email protected]>

refactor(PyO3): add explicit map_err

cda9980

refactor(PyO3): update comments

b35b748

refactor(PyO3): change from String to &str to avoid copy

9ce5a4b

fix(PyO3): typo in Changelog

80a12ea

refactor(PyO3): simplify struct field

5130d42

refactor(PyO3): clippy redundant closure

a9e21af

Manuthor reviewed Nov 14, 2022

View reviewed changes

ackRow and others added 2 commits November 14, 2022 09:28

refactor(PyO3): apply suggestions from Manuthor

5a5127d

Co-authored-by: Manuthor <[email protected]>

refactor(PyO3): update tabs in pyproject

69ea5d2

ThibaudDauce reviewed Nov 15, 2022

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

Hugo Rosenkranz-Costa added 3 commits November 15, 2022 10:13

build(PyO3): update cicd comments

e9100ef

build(PyO3): set crypto core version

b768315

fix(PyO3): remove crypto core git field

073e643

Manuthor merged commit 83157cb into feat/serialize_with_capacity Nov 15, 2022

Manuthor deleted the bindings-python branch November 15, 2022 10:41

tbrezot pushed a commit that referenced this pull request Nov 23, 2022

Bindings python (#65)

f69116c

* new python interfaces based on objects rather than functions covering a broader range of functionalities

tbrezot pushed a commit that referenced this pull request Nov 25, 2022

Bindings python (#65)

8685cf6

* new python interfaces based on objects rather than functions covering a broader range of functionalities

tbrezot pushed a commit that referenced this pull request Nov 25, 2022

Bindings python (#65)

647f30d

* new python interfaces based on objects rather than functions covering a broader range of functionalities

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bindings python #65

Bindings python #65

ackRow commented Nov 9, 2022 •

edited

Loading

tbrezot left a comment

Manuthor left a comment

Bindings python #65

Bindings python #65

Conversation

ackRow commented Nov 9, 2022 • edited Loading

Features

Technical choices

Limitations

tbrezot left a comment

Choose a reason for hiding this comment

Manuthor left a comment

Choose a reason for hiding this comment

ackRow commented Nov 9, 2022 •

edited

Loading