Add autofix protobuf job #2031
Merged
Add autofix protobuf job #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
force-pushed
the
co/autofix-protobuf
branch
from
54389e8
to
8e6b596
Compare
pinosu
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Nice work!
I think we don't have proto linting covered anywhere else, so it would be great if you could add it in here.
Also I noticed we can update the Makefile in such a way that we use the same protoImage also for proto-lint and proto-check-breaking by replacing @$(DOCKER_BUF) with @$(protoImage) buf .
This will make it straightforward also for the CI
|
Hmm, it seems there is something wrong with the autofix job? |
chipshort
force-pushed
the
co/autofix-protobuf
branch
from
42e3305
to
972ca13
Compare
chipshort
force-pushed
the
co/autofix-protobuf
branch
from
1e50ff7
to
d6890ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1967
Steps for the job are taken out of the Makefile's
proto-alljob.Should we also add a
proto-lintcheck to CI or does that already exist somewhere?