Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Assert no attributes used on self and ctx #459

Merged
merged 2 commits into from
Nov 20, 2024
Merged

feat: Assert no attributes used on self and ctx #459

merged 2 commits into from
Nov 20, 2024

Conversation

jawoznia
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.62069% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.95%. Comparing base (a7af42b) to head (40f5be6).
Report is 2 commits behind head on feat/replies.

Files with missing lines Patch % Lines
sylvia-derive/src/parser/mod.rs 36.84% 12 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           feat/replies     #459      +/-   ##
================================================
- Coverage         72.12%   71.95%   -0.18%     
================================================
  Files                63       63              
  Lines              3860     3879      +19     
================================================
+ Hits               2784     2791       +7     
- Misses             1076     1088      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@jawoznia jawoznia force-pushed the jawoznia/replies/verify-no-attrs-on-self-and-ctx branch from adaa241 to d9ee004 Compare November 19, 2024 14:27
kulikthebird
kulikthebird approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 and one comment

sylvia-derive/src/parser/mod.rs Outdated Show resolved Hide resolved
@jawoznia jawoznia force-pushed the jawoznia/replies/verify-no-attrs-on-self-and-ctx branch from f960579 to 40f5be6 Compare November 20, 2024 10:25
@jawoznia jawoznia merged commit 97fc158 into feat/replies Nov 20, 2024
7 of 9 checks passed
@jawoznia jawoznia deleted the jawoznia/replies/verify-no-attrs-on-self-and-ctx branch November 20, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulikthebird kulikthebird kulikthebird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawoznia @kulikthebird