Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe building contract and query creation #182

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

jawoznia
Copy link
Contributor

@jawoznia jawoznia commented Nov 7, 2024

Part of #176

@jawoznia jawoznia requested a review from hashedone November 7, 2024 12:45
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 1:31pm

Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please don't get discouraged by the number of comments - they're mostly nitpicks. The one thing I think is sort of important is the snake case one.

Overall it's still a very solid guide! :)

src/pages/tutorial/cw-contract/_meta.json Outdated Show resolved Hide resolved
src/pages/tutorial/cw-contract/building-contract.mdx Outdated Show resolved Hide resolved
src/pages/tutorial/cw-contract/building-contract.mdx Outdated Show resolved Hide resolved
src/pages/tutorial/cw-contract/building-contract.mdx Outdated Show resolved Hide resolved
src/pages/tutorial/cw-contract/building-contract.mdx Outdated Show resolved Hide resolved
src/pages/tutorial/cw-contract/query.mdx Outdated Show resolved Hide resolved
src/pages/tutorial/cw-contract/query.mdx Outdated Show resolved Hide resolved
src/pages/tutorial/cw-contract/query.mdx Outdated Show resolved Hide resolved
message: String,
}

#[derive(Serialize, Deserialize)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our convention is to encode enum variants as snake_case JSON names. We either use the rename_all Serde attribute or go through the cw_serde macro.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for the cw_serde comment. Since we introduce concept of JSON schema in later pages the idea is to keep new information to minimum.

src/pages/tutorial/cw-contract/query.mdx Outdated Show resolved Hide resolved
@jawoznia jawoznia force-pushed the cw-tutorial/contract-creation branch from c8f1820 to dec495d Compare November 14, 2024 12:48
Base automatically changed from cw-tutorial/contract-creation to main November 14, 2024 12:54
@jawoznia jawoznia force-pushed the cw-tutorial/building-and-query branch from 26e5cf6 to 2fa197c Compare November 14, 2024 13:28
@jawoznia jawoznia merged commit ae6e8a9 into main Nov 18, 2024
6 checks passed
@jawoznia jawoznia deleted the cw-tutorial/building-and-query branch November 18, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants