-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe building contract and query creation #182
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Please don't get discouraged by the number of comments - they're mostly nitpicks. The one thing I think is sort of important is the snake case one.
Overall it's still a very solid guide! :)
message: String, | ||
} | ||
|
||
#[derive(Serialize, Deserialize)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our convention is to encode enum variants as snake_case JSON names. We either use the rename_all
Serde attribute or go through the cw_serde
macro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for the cw_serde
comment. Since we introduce concept of JSON schema in later pages the idea is to keep new information to minimum.
c8f1820
to
dec495d
Compare
26e5cf6
to
2fa197c
Compare
Part of #176