Keep new() identical for ibc1 and ibc3 #1304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I doubt this helps as we have the same problem in the structs like |
ethanfrey
force-pushed
the
add-ibc-v3-support
branch
from
392da4c to
ada176f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional addition to #1302
This would make the ibc3 feature flag less breaking compile time. It would use a default value for relayer if not explicitly provided. These functions are only really used by the mock tooling as far as I know.
Merge if you like or reject if it is not an improvement. It is an attempt to address some PR comments.