v1 #743

[jstet]

• Changed Filter component so checkboxes can dynamically be included

• Added Icon to right corner of projects card
• added application link in cms and to the card and single project view

@pr130 If you agree with these changes (see deployed preview), feel free to accept the PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
correlaid	⬜️ Ignored (Inspect)	Visit Preview		Jul 17, 2024 8:12am

[jstet]

Whoops typo, fixed below

[cloudflare-workers-and-pages]

Deploying correlaid with    Cloudflare Pages

Latest commit:	a1bd129
Status:	✅  Deploy successful!
Preview URL:	https://b6fff8b9.correlaid.pages.dev
Branch Preview URL:	https://741-projects-card-add-status.correlaid.pages.dev

View logs

[pr130]

Thanks @jstet :

• regarding the icon: can we do something that is more "search" oriented? or "team"? or "application"? there are some icons on the icon noun project but i can't figure out how to download them (and the website is extra buggy right now 😭 )
• no prio but minor bug: if you tick the checkbox and change the language, the checkbox remains ticked, but it's not filtered anymore and all projects are shown. but i suppose this is one of those "looks minor but is complicated things" so no prio on that bc that is not a regular user behaviour. :D

changed myself and pushed (hopefully you agree):

• checkbox filter wording in german: change to "Bewerbungsphase läuft"
• Jetzt bewerben and Apply now instead of only bewerben/apply
• clicking on the icon gives 404 -> https://775d37a2.correlaid.pages.dev/en/using-data/project-database/google.com/ -> should this even be clickable? i do not think it's necessary.

[pr130]

i removed the "Jetzt bewerben" link bc i don't think it's good because it gives ppl the option to "bypass" reading the call to applications. also changed the wording again and made it red to make it more visually clear. hope that doesn't break your design totally. 😬

[jstet]

• Icon link mistakenly survived from former icon. thanks for removing it.
• language change issue: Filter: handle language change more gracefully #763 this is also a problem for the selects, i will fix it later :D
• i will look for a new icon: my logic was that we also used it in the ctas at the bottom of https://www.correlaid.org/bildung/r-lernen/
• re the "jetzt bewerben" field instead of link: I agree with avoiding the shortcut. However I am not sure if we should use the correlaidx colour for stuff like this and i feel adding a notice like that looks a bit disruptive and too vanilla. also with the icon, the teaser we would have three indications that one can apply and i feel like thats too much.

[jstet]

@pr130 could u send a link to the icons you liked? I found this one: https://thenounproject.com/icon/search-profile-4223974/

[pr130]

this looks great!

[pr130]

re wording: good point.. then we just have to use the teaser field to write something like "apply now!" . i'll make note of that for the project people. 📝 then i'd opt for nothing at all below the teaser.

[jstet]

Alrighty, thanks. I will implement what we agreed on :)