Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plume file integration #1

Merged
merged 15 commits into from
Dec 14, 2023

Conversation

lucas-amiaud
Copy link
Collaborator

No description provided.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
this.fileEntity = fileEntity;
this.joinColumn = joinColumn;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saut de ligne en trop

@amanteaux
Copy link
Member

Et ça serait cool dans le readme d'expliquer un peu comment on teste la partie fichier

pom.xml Outdated Show resolved Hide resolved
public enum ShowcaseFileType implements FileTypeDatabase {
// could be SAMPLE(QUserFile.userFile, QUserFile.userFile.fileUniqueName)
PICTURE(null, null),
EXCEL(null, null),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça serait bien d'aller au bout de l'exemple et de mettre les fichiers dans une table en base de données. On pourrait ensuite exposer sommairement les données depuis le FileUploadWs

.fileMaxSize(2_000_000)
.fileNameAllowEmpty()
.fileNameMaxLength(255)
.fileExtensionAllowEmpty()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu veux pas utiliser plutôt la méthode fileImage() ? C'est tout de même plus adapter pour l'upload d'une image

.fileNameAllowEmpty()
.fileNameMaxLength(255)
.fileTypeNotEmpty()
.mimeTypes(Set.of(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour l'upload de fichier Excel, je mettrai plutôt un exemple avec les extensions .xls et .xlsx. Quitte à mettre un commentaire expliquant qu'on peut valider par mime type si besoin

Comment on lines 26 to 27
`picture_unique_name` VARCHAR(255) NOT NULL,
`excel_unique_name` VARCHAR(255) NOT NULL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peut être plutôt appeler ça file_picture_filename non ?

@amanteaux amanteaux merged commit ce65771 into Coreoz:master Dec 14, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants