visual selection #735
Closed
visual selection #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `nvim_buf_get_text` instead of `nvim_buf_get_lines` to properly handle column positions in visual selections. Add special handling for Visual Line mode by adjusting start and end columns accordingly.
for more information, see https://pre-commit.ci
- Updated `get_selection` and `highlight_selection` functions to handle start and end columns for more precise selection highlighting. - Modified `ask` function to maintain consistent indentation. - Added `start_col` and `end_col` fields to selection object in `select.lua`.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this #734 is a bug or intentional.
My scenario is:
I have a use case to search for current highlighted text in a chat. If i use
select.visual, the selection would highlight the entire line as the context, instead of the highlighted text.So instead of
vim.api.nvim_buf_get_lines, i usenvim_buf_get_textto get the exact text i want as the context to the chat, and added a state to track the vim mode. To be honest, I didn't test this intensively, let me know if I am doing something wrong 😄.