Let's return encoding and source by reference and move all the variab…

…les with the move constructor
CopernicaMarketingSoftware · Nov 3, 2014 · 3fa3d33 · 3fa3d33
1 parent d4e42e0
commit 3fa3d33
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/include/template.h b/include/template.h
@@ -68,10 +68,12 @@ class Template
 
     /**
      *  Move constructor
+     *  @param  that
      */
     Template(Template &&that)
     : _executor(that._executor),
-      _encoding(std::move(that._encoding)) {
+      _encoding(std::move(that._encoding)),
+      _source(std::move(that._source)) {
       that._executor = nullptr;
     }
 
@@ -143,12 +145,12 @@ class Template
     /**
      *  Used to retrieve what encoding this template is in, natively
      */
-    const std::string encoding() const { return _encoding; };
+    const std::string &encoding() const { return _encoding; };
 
     /**
      *  Retrieve the original source of this template
      */
-    const std::string source() const { return _source; };
+    const std::string &source() const { return _source; };
 };
 
 /**