Create FreeBSD-specific Makefile #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 17, 2020 09:08
Third-party applications on FreeBSD/HardenedBSD install into /usr/local. Signed-off-by: Shawn Webb <[email protected]> Sponsored-by: BlackhawkNest, Inc
Signed-off-by: Shawn Webb <[email protected]> Sponsored-by: BlackhawkNest, Inc
Signed-off-by: Shawn Webb <[email protected]> Sponsored-by: BlackhawkNest, Inc
Signed-off-by: Shawn Webb <[email protected]> Sponsored-by: BlackhawkNest, Inc
Since I created a FreeBSD-specific Makefile, there's no need to modify the primary Makefile. Signed-off-by: Shawn Webb <[email protected]> Sponsored-by: BlackhawkNest, Inc
Also, default to /usr/local if PREFIX is undefined. Signed-off-by: Shawn Webb <[email protected]>
Signed-off-by: Shawn Webb <[email protected]>
When telling the BSD build infrastructure where to find source code files, the order matters. In this repo, there are some source code files with the same file name that live in /common and /zend. For example, /common/streambuf.cpp and /zend/streambuf.cpp. It seams that the former is scaffolding while the latter is the complete implementation. With this fix, PHP is able to load a custom extension that builds on top of PHP-CPP. PHP Warning: PHP Startup: Unable to load dynamic library '/usr/home/shawn/projects/php-lib[sanitized]/obj/libphp-lib[sanitized].so' (tried: /usr /home/shawn/projects/php-lib[sanitized]/obj/libphp-lib[sanitized].so (/usr/local/lib/libphpcpp.so.2.2.0: Undefined symbol "_ZN3Php9StreamBuf4sync Ev"), /usr/local/lib/php/20190902//usr/home/shawn/projects/php-lib[sanitized]/obj/libphp-lib[sanitized].so.so (Cannot open "/usr/local/lib/php/20 190902//usr/home/shawn/projects/php-lib[sanitized]/obj/libphp-lib[sanitized].so.so")) in Unknown on line 0 Signed-off-by: Shawn Webb <[email protected]>
Rename /common/streambuf.cpp to /common/common_streambuf.cpp to address file name conflict with /zend/streambuf.cpp. Signed-off-by: Shawn Webb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
Makefile.FreeBSDthat is friendly with the bsdmake framework. This allows for easy integration into the FreeBSD ports tree.Sponsored-by: BlackhawkNest, Inc