Fix cmake script to compile as submodule #399
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that the PHP-CPP library cannot be compiled with
cmake
if it is used as git submodule.The main problems:
CMakeLists.txt has syntax errors
It is not contain all necessary options and has syntax errors in static linking
The placement of header files
Library headers are placed in /include directory, the main header
phpcpp.h
includes it in the following way:#include <phpcpp/visibility.h>
Even if I add directory
/includes
to header search paths, the compiler will wearch header in/includes/phpcpp
directory.That is not problem, if I compile the library with
make
and install it withmake install
, headers are placed in the system directories properly. But this becomes a problem if I do not want to install the library. Creating symlinks is the ugly way.