Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some major bugs are fixed on OSX. #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some major bugs are fixed on OSX. #10

wants to merge 2 commits into from

Conversation

neyaoz
Copy link

@neyaoz neyaoz commented May 19, 2017

Uninstall options is copied from v2, and some bugs are fixed:

Bug: ld: unknown option: -soname (on macOS)
Bug: mkdir: /usr/include/phpcpp: Operation not permitted (on macOS \w SIP)

I have updated "soname" option as "install_name" for macOS. But I think all we have to do is make a conditional for macOS. I'll investigate tonight. (Edit: I've done.)

@neyaoz
Copy link
Author

neyaoz commented May 19, 2017

Also, I have added "-undefined dynamic_lookup" linker option as default for macOS.

@@ -94,7 +108,7 @@ endif
# you want to leave that flag out on production servers).
#

COMPILER_FLAGS = -Wall -c -std=c++11 -fvisibility=hidden -MD -DBUILDING_PHPCPP -Wno-write-strings
COMPILER_FLAGS = -Wall -c -std=c++11 -fvisibility=hidden -DBUILDING_PHPCPP -Wno-write-strings -MD
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant