Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support batch items failure report in sqs #251

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: support batch items failure report in sqs #251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0061910
feat: support batch items failure report in sqs
emahnovets Aug 4, 2023
a7fd4c7
refactor: fix naming for variable
emahnovets Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions packages/serverless-offline-sqs/src/sqs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class SQS {
}

async _sqsEvent(functionKey, sqsEvent) {
const {enabled, arn, queueName, batchSize = 10} = sqsEvent;
const {enabled, arn, queueName, batchSize = 10, functionResponseType} = sqsEvent;

if (!enabled) return;

Expand All @@ -109,6 +109,18 @@ class SQS {
return getMessages(size - Messages.length, [...messages, ...Messages]);
};

const getSuccessfullyProcessedMessages = (messages, result) => {
if (functionResponseType !== 'ReportBatchItemFailures') {
return messages;
}

const failedMessageIds = new Set(
result?.batchItemFailures?.map(message => message?.itemIdentifier) ?? []
);

return messages.filter(({MessageId}) => !failedMessageIds.has(MessageId));
};

const job = async () => {
const messages = await getMessages(batchSize);

Expand All @@ -119,12 +131,13 @@ class SQS {
const event = new SQSEvent(messages, this.region, arn);
lambdaFunction.setEvent(event);

await lambdaFunction.runHandler();
const result = await lambdaFunction.runHandler();
const messagesToDelete = getSuccessfullyProcessedMessages(messages, result);

await Promise.all(
chunk(
10,
(messages || []).map(({MessageId: Id, ReceiptHandle}) => ({
(messagesToDelete || []).map(({MessageId: Id, ReceiptHandle}) => ({
Id,
ReceiptHandle
}))
Expand Down