Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Updating the alarm log message POJOs based on #3304 #3314

Closed
wants to merge 2 commits into from

Conversation

shroffk
Copy link
Member

@shroffk shroffk commented Mar 6, 2025

work in progress... trying to fix #3304

@shroffk shroffk requested a review from tynanford March 6, 2025 07:16
@tynanford
Copy link
Contributor

Thanks. It seems a bit wrong that "enabled" now will be returning a string for the logger API and clients have to know what the date string means. But it nicely allows for the client to show the disable until info in the log table and is a good fix for now.

It's getting late and might be doing something silly. Will re-visit tomorrow

... but right now it seems like the "enabled" field is missing from the API results with this patch. So en is always null

Before:

severity	"OK"
message	"Disabled"
value	""
time	"2025-03-06T09:08:37.805Z"
current_severity	"OK"
current_message	"OK"
message_time	"2025-03-06T09:08:37.805Z"
config	"state:/Accelerator/Test/Accelerator:Alarm:BoolInvalid"
pv	"Accelerator:Alarm:BoolInvalid"
enabled	false

With this change:

severity	"OK"
message	"Disabled"
value	""
time	"2025-03-06T09:08:37.805Z"
current_severity	"OK"
current_message	"OK"
message_time	"2025-03-06T09:08:37.805Z"
config	"state:/Accelerator/Test/Accelerator:Alarm:BoolInvalid"
pv	"Accelerator:Alarm:BoolInvalid"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible issue with alarm "disable until" menu and "enabled" field in kafka and elasticsearch
2 participants