This repository has been archived by the owner on Jul 5, 2021. It is now read-only.
Test failure for secret creation when backend fails. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 85.44% 86.59% +1.14%
==========================================
Files 9 9
Lines 261 261
==========================================
+ Hits 223 226 +3
+ Misses 28 26 -2
+ Partials 10 9 -1
Continue to review full report at Codecov.
|
knelasevero
reviewed
Oct 19, 2020
knelasevero
approved these changes
Oct 19, 2020
|
@allanmoso this PR qualifies for our Hacktoberfest campaign! See https://blog.container-solutions.com/container-solutions-does-hacktoberfest for more details. (Allan replied so removing my e-mail) |
amouat
pushed a commit
that referenced
this pull request
May 26, 2021
…8s.io/apimachinery-0.21.0 chore(deps): bump k8s.io/apimachinery from 0.20.5 to 0.21.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to improve the test coverage for the controllers/secrets/externalsecret_controller.go as part of #103
This is as much as I can do for now. The only other parts in the code that is not covered by unit test is inside the Reconcile loop.