Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Verison Flag to CLI #560

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Kim-Hyo-Bin
Copy link
Contributor

containerssh issue 422

Added a 'version' variable to store version information
Implemented 'printVersion', 'runVersionCheck' function to print the current version using the '--version' flag

image


By contributing to this repository, I agree to the contribution guidelines.

Added a 'version' variable to store version information
Implemented 'printVersion', 'runVersionCheck' function to print the current version using the '--version' flag

Signed-off-by: HyoBin Kim <[email protected]>
@Kim-Hyo-Bin
Copy link
Contributor Author

If more flags are added, it seems like we'll need to split the file for management.
However, since this package operates in containers/pods, the usage of commands is minimal.
it' just an opinion.

Copy link
Member

@tsipinakis tsipinakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and looking into this, I was meaning to add this before 0.5 but never got around to it.
(As well as address the - vs -- param inconsistency)

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@2b50b03). Click here to learn what that means.

❗ Current head 44d99b2 differs from pull request most recent head 33e0d2e. Consider uploading reports for the commit 33e0d2e to get more accurate results

Files Patch % Lines
main.go 0.00% 49 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage        ?   37.23%           
=======================================
  Files           ?      196           
  Lines           ?    17242           
  Branches        ?        0           
=======================================
  Hits            ?     6420           
  Misses          ?    10232           
  Partials        ?      590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Kim-Hyo-Bin and others added 2 commits February 16, 2024 10:52
Co-authored-by: Nikos Tsipinakis <[email protected]>
Signed-off-by: okestro-hbkim <[email protected]>
package debug using ReadBuildInfo()

for relative version info

Signed-off-by: HyoBin Kim <[email protected]>
main.go Show resolved Hide resolved
add more build info debug options
revision, goversion.. etc

Signed-off-by: HyoBin Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants