Skip to content

Commit

Permalink
Merge pull request #296 from ConsumerDataStandardsAustralia/defect/280
Browse files Browse the repository at this point in the history
Fixed typo
  • Loading branch information
JamesMBligh authored Aug 23, 2023
2 parents d67fe0e + cf16344 commit eb5d775
Show file tree
Hide file tree
Showing 13 changed files with 22 additions and 11 deletions.
2 changes: 1 addition & 1 deletion docs/includes/cds_banking
Original file line number Diff line number Diff line change
Expand Up @@ -8271,7 +8271,7 @@ This operation does not require authentication
<td>» bundleName</td>
<td>string</td>
<td>optional</td>
<td>Optional field to indicate if this account is part of a bundle that is providing additional benefit for to the customer</td>
<td>Optional field to indicate if this account is part of a bundle that is providing additional benefit to the customer</td>
</tr>
<tr>
<td>» specificAccountUType</td>
Expand Down
7 changes: 6 additions & 1 deletion docs/includes/releasenotes/releasenotes.1.26.0.html
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ <h2 id='changes-made'>Changes Made</h2><h3 id='change-requests'>Change Requests<
<p>This release addresses the following minor defects raised on <a href="https://github.com/ConsumerDataStandardsAustralia/standards-staging/issues">Standards Staging</a>:</p>

<ul>
<li>TBD</li>
<li><a href="https://github.com/ConsumerDataStandardsAustralia/standards-staging/issues/280">Staging Issue 280 - Typo in Account Detail bundleName description</a></li>
</ul>

<p>This release addresses the following change requests raised on <a href="https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues">Standards Maintenance</a>:</p>
Expand Down Expand Up @@ -288,6 +288,11 @@ <h2 id='api-end-points'>API End Points</h2>
<td>Changes to the obligation dates for Get Metrics v3 as determined in <a href="https://github.com/ConsumerDataStandardsAustralia/standards/issues/322">Decision 322</a></td>
<td><a href="../../#admin-apis">Admin APIs</a></td>
</tr>
<tr>
<td>bundleName Typo</td>
<td>Typo in bundleName field description</td>
<td><a href="../../#admin-apis">Admin APIs</a></td>
</tr>
</tbody></table>
<h2 id='information-security-profile'>Information Security Profile</h2>
<p>No Change</p>
Expand Down
2 changes: 1 addition & 1 deletion docs/includes/swagger/cds_banking.json
Original file line number Diff line number Diff line change
Expand Up @@ -5644,7 +5644,7 @@
"type" : "string"
},
"bundleName" : {
"description" : "Optional field to indicate if this account is part of a bundle that is providing additional benefit for to the customer",
"description" : "Optional field to indicate if this account is part of a bundle that is providing additional benefit to the customer",
"type" : "string"
},
"specificAccountUType" : {
Expand Down
2 changes: 1 addition & 1 deletion docs/includes/swagger/cds_banking.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7128,7 +7128,7 @@ components:
type: string
bundleName:
description: Optional field to indicate if this account is part of a bundle
that is providing additional benefit for to the customer
that is providing additional benefit to the customer
type: string
specificAccountUType:
description: The type of structure to present account specific fields.
Expand Down
2 changes: 1 addition & 1 deletion docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -21081,7 +21081,7 @@ <h3 class="schema-toc" id="tocSbankingaccountdetailv3">BankingAccountDetailV3</h
<td>» bundleName</td>
<td>string</td>
<td>optional</td>
<td>Optional field to indicate if this account is part of a bundle that is providing additional benefit for to the customer</td>
<td>Optional field to indicate if this account is part of a bundle that is providing additional benefit to the customer</td>
</tr>
<tr>
<td>» specificAccountUType</td>
Expand Down
5 changes: 5 additions & 0 deletions slate/source/includes/_banking_apis.md.erb
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ This specification defines the APIs for Data Holders exposing Banking endpoints.
<tr><td><a href='./includes/swagger/cds_banking.yaml'>Banking OpenAPI Specification (YAML)</a></td></tr>
</table>

```diff
Fixed typo in the description of the bundleName field
in the BankingAccountDetailV3 model
```

<%= partial "includes/cds_banking.md" %>
<%= partial "includes/banking/_product_categories.md" %>
<%= partial "includes/banking/_product_components.md" %>
2 changes: 1 addition & 1 deletion slate/source/includes/cds_banking.md
Original file line number Diff line number Diff line change
Expand Up @@ -4853,7 +4853,7 @@ This operation does not require authentication
|*anonymous*|object|mandatory|none|
|» bsb|string|optional|The unmasked BSB for the account. Is expected to be formatted as digits only with leading zeros included and no punctuation or spaces|
|» accountNumber|string|optional|The unmasked account number for the account. Should not be supplied if the account number is a PAN requiring PCI compliance. Is expected to be formatted as digits only with leading zeros included and no punctuation or spaces|
|» bundleName|string|optional|Optional field to indicate if this account is part of a bundle that is providing additional benefit for to the customer|
|» bundleName|string|optional|Optional field to indicate if this account is part of a bundle that is providing additional benefit to the customer|
|» specificAccountUType|string|optional|The type of structure to present account specific fields.|
|» termDeposit|[[BankingTermDepositAccount](#schemacdr-banking-apibankingtermdepositaccount)]|conditional|none|
|» creditCard|[BankingCreditCardAccount](#schemacdr-banking-apibankingcreditcardaccount)|conditional|none|
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Release notes for version v1.26.0 of the [CDR Standards](../../index.html).

This release addresses the following minor defects raised on [Standards Staging](https://github.com/ConsumerDataStandardsAustralia/standards-staging/issues):

- TBD
- [Staging Issue 280 - Typo in Account Detail bundleName description](https://github.com/ConsumerDataStandardsAustralia/standards-staging/issues/280)

This release addresses the following change requests raised on [Standards Maintenance](https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues):

Expand All @@ -42,6 +42,7 @@ No Change
|Change|Description|Link|
|------|-----------|----|
| Modified Get Metrics Obligations | Changes to the obligation dates for Get Metrics v3 as determined in [Decision 322](https://github.com/ConsumerDataStandardsAustralia/standards/issues/322) | [Admin APIs](../../#admin-apis) |
| bundleName Typo | Typo in bundleName field description | [BankingAccountDetailV3](../../#tocSbankingaccountdetailv3) |

## Information Security Profile

Expand Down
2 changes: 1 addition & 1 deletion slate/source/includes/swagger/cds_banking.json
Original file line number Diff line number Diff line change
Expand Up @@ -5644,7 +5644,7 @@
"type" : "string"
},
"bundleName" : {
"description" : "Optional field to indicate if this account is part of a bundle that is providing additional benefit for to the customer",
"description" : "Optional field to indicate if this account is part of a bundle that is providing additional benefit to the customer",
"type" : "string"
},
"specificAccountUType" : {
Expand Down
2 changes: 1 addition & 1 deletion slate/source/includes/swagger/cds_banking.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7128,7 +7128,7 @@ components:
type: string
bundleName:
description: Optional field to indicate if this account is part of a bundle
that is providing additional benefit for to the customer
that is providing additional benefit to the customer
type: string
specificAccountUType:
description: The type of structure to present account specific fields.
Expand Down
2 changes: 1 addition & 1 deletion swagger-gen/api/cds_banking.json
Original file line number Diff line number Diff line change
Expand Up @@ -4285,7 +4285,7 @@
},
"bundleName": {
"type": "string",
"description": "Optional field to indicate if this account is part of a bundle that is providing additional benefit for to the customer"
"description": "Optional field to indicate if this account is part of a bundle that is providing additional benefit to the customer"
},
"specificAccountUType": {
"type": "string",
Expand Down
2 changes: 1 addition & 1 deletion swagger-gen/cds_banking.md
Original file line number Diff line number Diff line change
Expand Up @@ -4853,7 +4853,7 @@ This operation does not require authentication
|*anonymous*|object|mandatory|none|
|» bsb|string|optional|The unmasked BSB for the account. Is expected to be formatted as digits only with leading zeros included and no punctuation or spaces|
|» accountNumber|string|optional|The unmasked account number for the account. Should not be supplied if the account number is a PAN requiring PCI compliance. Is expected to be formatted as digits only with leading zeros included and no punctuation or spaces|
|» bundleName|string|optional|Optional field to indicate if this account is part of a bundle that is providing additional benefit for to the customer|
|» bundleName|string|optional|Optional field to indicate if this account is part of a bundle that is providing additional benefit to the customer|
|» specificAccountUType|string|optional|The type of structure to present account specific fields.|
|» termDeposit|[[BankingTermDepositAccount](#schemacdr-banking-apibankingtermdepositaccount)]|conditional|none|
|» creditCard|[BankingCreditCardAccount](#schemacdr-banking-apibankingcreditcardaccount)|conditional|none|
Expand Down

0 comments on commit eb5d775

Please sign in to comment.